Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fields for keys/values in DictField #245

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Use fields for keys/values in DictField #245

merged 1 commit into from
Apr 18, 2020

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented Apr 16, 2020

Closes #99.

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.5%) to 83.77% when pulling 9d38ea7 on dict_field into 9485f02 on master.

@coveralls
Copy link

coveralls commented Apr 16, 2020

Coverage Status

Coverage decreased (-0.5%) to 95.723% when pulling 4282b0b on dict_field into 9485f02 on master.

@lafrech lafrech force-pushed the dict_field branch 4 times, most recently from ef1d629 to 6ddc0aa Compare April 17, 2020 20:53
@lafrech lafrech added this to the 3.0 milestone Apr 17, 2020
@lafrech
Copy link
Collaborator Author

lafrech commented Apr 18, 2020

This implementation allows the user to optionnaly use fields for keys and/or values.

Any type of field can be used, so it is up to the user not to pick a field that doesn't make sense for a key. Generally, fields that serialize immutable stuff serialize as string, so it should work, but then the user should be careful when querying (see #99 (comment)). Nothing really new (see #185).

@lafrech lafrech marked this pull request as ready for review April 18, 2020 16:55
@lafrech lafrech merged commit 76989d9 into master Apr 18, 2020
@lafrech lafrech deleted the dict_field branch April 18, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DictField limitations
2 participants