Use txmongo's find_with_cursor method #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a deprecation warning due to API changes in txmongo.
I had to bump minimal txmongo version to 19.2.0 (latest) for the tests to pass. I think we should be able to support older versions. I suspect I just didn't find the proper pymongo, twmongo and perhaps twisted and pytest-twisted combination. The incomplete changelog didn't help. I went through the commits in txmongo and couldn't find the reason versions prior to 19.2.0 would fail.
I don't mind bumping this since it is only a test dependency, and we're releasing a major version, but for the sake of understanding and because it would be nice to know which txmongo versions are supported, explanation welcome.
BTW, @wfscheper, I hope you're doing well and I'd be glad to get some feedback on umongo 3 beta if you can find the time to give it a try.