Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework abstract EmbeddedDocument policy to match Document #269

Merged
merged 1 commit into from May 4, 2020
Merged

Rework abstract EmbeddedDocument policy to match Document #269

merged 1 commit into from May 4, 2020

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented May 4, 2020

Closes #86.

Rebase of @touilleMan's branch.

@lafrech lafrech added this to the 3.0 milestone May 4, 2020
@lafrech lafrech mentioned this pull request May 4, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 95.595% when pulling b71f1b7 on rework-abstract-embedded-doc into dd07a0e on master.

@lafrech lafrech merged commit 2f3322c into master May 4, 2020
@lafrech lafrech deleted the rework-abstract-embedded-doc branch May 4, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Should EmbeddedDocument child of abstract EmbeddedDocument have a cls field?
3 participants
@lafrech @coveralls @touilleMan