Remove allow_inheritance #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafrech
force-pushed
the
remove_allow_inheritance
branch
from
ebb4962
to
28b9c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature behaves differently on
DocumentandEmbeddedDocument.As I was about to make both consistent, I realized that I didn't really see the point of the feature. It seems to only serve the purpose of triggering an exception if someone tries to inherit a document class that was not meant to. It has no influence on the
clsfield.Let's assume we know what we're doing and, rather than default to
allow_inheritance=TrueforDocumentto matchEmbeddedDocument, remove the feature.