Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia issue 97 #98

Closed
wants to merge 4 commits into from
Closed

Julia issue 97 #98

wants to merge 4 commits into from

Conversation

getzze
Copy link
Contributor

@getzze getzze commented Aug 3, 2022

closes #97

EDIT: now a correct "bad before; good after" example.

table[]!='#'

is now parsed correctly as table identifier, [] brackets, != operator and '#' character.
Instead of table identifier, [] brackets, !=' operator and #' comment (because the first ' was incorrectly parsed as adjoint)

Also update unicode characters allowed as identifiers.

@nyamatongwe
Copy link
Member

Committed the 7eaf635 change set with examples in x.jl as 84f9a6c. Pull requests should include short test cases that show 'bad before; good after' so they can be checked and will remain fixed.

The above example doesn't parse as stated since ! is part of the table! identifier.

Lexing result both before and after e267314

{9}table!{7}={6}'#'{0}

However, it does fix the originating problem and this simplified example:

table[d]!='#' for d=[(1,0),(-1,0),(0,1),(0,-1)]

@getzze
Copy link
Contributor Author

getzze commented Aug 5, 2022

Sorry, I put a bad example (I edited the first message).

I added a commit with a test case.

nyamatongwe pushed a commit that referenced this pull request Aug 6, 2022
@nyamatongwe nyamatongwe added julia Caused by the julia lexer committed Issue fixed in repository but not in release labels Aug 6, 2022
@nyamatongwe
Copy link
Member

Committed.

@nyamatongwe nyamatongwe mentioned this pull request Aug 6, 2022
@nyamatongwe
Copy link
Member

Included in 5.1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Issue fixed in repository but not in release julia Caused by the julia lexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia
2 participants