This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
adds macos support to portaudio #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
#125 added support for realtime audio ingestion on Linux. This PR adds the same support for macOS. Windows is to follow.
Implementation
Tested and verified the PortAudio setup on a Mac. This uncovered that the StageManager software still had a race in CommandBuffer deletion, so devised a better method to fix the race. Started to organize the PortAudio class a bit better to centralize the os-specific logic into methods.
Types of changes
Status