This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Finalize names and begin support for VGen rates #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
The (hopefully) final names for the thee rates VGens run at are
frame,shape, andpixel. Adds support to the VGen and ScinthDef specifications for providing those rates, and documents supported rates for each of the exiting VGens.Implementation
Repurposes the
.frto mean frame rate and adds.srand.prmethods to support the new rate names. Adds support for parsing ScinthDef and VGen yaml with rate descriptions. Adds ScinthDef code to validate that rates only increase from input to output. Add some supported rate checking on VGen validation.Types of changes
Status