This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Add crash detection and report uploading on Linux #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
This started as an investigation into the intermittent crash #115 and how I might be able to get better crash data and has since mushroomed into a system to ingest crash reports, with user consent, from any crashing scinsynth in production. This adds a compile-time dependency to the Crashpad client, which is compiled and installed in the separate crashpad-ext repository, like many other scinserver dependencies.
Implementation
Adds a src/infra/CrashReporter client which will launch an external monitoring process, the crash_handler binary included as part of the Crashpad build. This binary will monitor the scinserver process and if it crashes it will create a crash report, mostly including the call stack of every thread running, and deposit the data as a minidump file in the crash database. This file database is configured to live in the .crash_reports directory inside of the Scintillator quark root folder.
Adds OSC commands and some supporting sclang code to allow users to enumerate the crash reports in the database and upload individual reports or all unuploaded reports. Adds some discussion of the potential privacy implications of the reports along with documentation about how to upload the reports.
Types of changes
Status