Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add crash detection and report uploading on Linux #137

Merged
merged 36 commits into from
Jul 23, 2020

Conversation

lnihlen
Copy link
Member

@lnihlen lnihlen commented Jul 21, 2020

Purpose and motivation

This started as an investigation into the intermittent crash #115 and how I might be able to get better crash data and has since mushroomed into a system to ingest crash reports, with user consent, from any crashing scinsynth in production. This adds a compile-time dependency to the Crashpad client, which is compiled and installed in the separate crashpad-ext repository, like many other scinserver dependencies.

Implementation

Adds a src/infra/CrashReporter client which will launch an external monitoring process, the crash_handler binary included as part of the Crashpad build. This binary will monitor the scinserver process and if it crashes it will create a crash report, mostly including the call stack of every thread running, and deposit the data as a minidump file in the crash database. This file database is configured to live in the .crash_reports directory inside of the Scintillator quark root folder.

Adds OSC commands and some supporting sclang code to allow users to enumerate the crash reports in the database and upload individual reports or all unuploaded reports. Adds some discussion of the potential privacy implications of the reports along with documentation about how to upload the reports.

Types of changes

  • Enhancement
  • Documentation

Status

  • This PR is ready for review
  • Unit tests added
  • Unit tests are passing

@lnihlen lnihlen merged commit c027fef into ScintillatorSynth:master Jul 23, 2020
@lnihlen lnihlen deleted the topic/crashpad branch July 23, 2020 02:35
@lnihlen lnihlen mentioned this pull request Jul 23, 2020
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant