This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
create avbuffers to be 32-byte aligned in width #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnihlen
added a commit
that referenced
this pull request
Aug 31, 2020
* create avbuffers to be 32-byte aligned in width (#154) * implementation of cmd-period (#155) * switch travis to xenial (#157) * Turn on all warnings, and treat warnings as compilation errors (#158) * Adds preliminary support for Groups to scinserver (#162) * Adds group and node ordering to scinsynth (#163) * include libstdc++ and libgcc_s in AppImage (#167) * fix apprun based on vanilla xenial testing (#168) * bump version to 0.0.8 (#169)
nhthn
pushed a commit
to nhthn/Scintillator
that referenced
this pull request
Sep 27, 2020
* create avbuffers to be 32-byte aligned in width (ScintillatorSynth#154) * implementation of cmd-period (ScintillatorSynth#155) * switch travis to xenial (ScintillatorSynth#157) * Turn on all warnings, and treat warnings as compilation errors (ScintillatorSynth#158) * Adds preliminary support for Groups to scinserver (ScintillatorSynth#162) * Adds group and node ordering to scinsynth (ScintillatorSynth#163) * include libstdc++ and libgcc_s in AppImage (ScintillatorSynth#167) * fix apprun based on vanilla xenial testing (ScintillatorSynth#168) * bump version to 0.0.8 (ScintillatorSynth#169)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
Fixes #143. FFMPEG, for some codecs, requires that the image data be 32-byte aligned along pixel rows. This allows images of arbitrary sizes to now be saved correctly, and updates the image integration tests to use prime numbers for image sizes in both dimensions, hopefully catching any future alignment errors that pop up.
Implementation
Adds a
stridemember to VulkanHostBufferclass as well as the wrapperav::Bufferclass that represents that host-accessible memory area to the av subsystem. Computesstrideto be 32-byte aligned. Update the test image reference version to account for the resized images.Types of changes
Status