This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Delay StatusPoller OSCFunc/SkipJack instantiation until server boot #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
Fix #172.
Implementation
ScinServerStatusPoller, on initialization, no longer automatically creates its OSCFunc/SkipJack. The creation of these monitoring objects is deferred until the
start
instance method is called on the ScinServerStatusPoller.This fixes what appears to be a race condition when creating an OSCFunc during class tree initialization, and also prevents the ScinServerStatusPoller from being broken by a CmdPeriod call between instantiation of the server and booting of the server. It does not yet make the StatusPoller entirely impervious to CmdPeriod.
Types of changes
Status