This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
Previously, ScinServer created the ScinServerStatusPoller during init, and created its NetAddr while booting. This meant that unless you booted immediately, the status poller would error, trying to poll
nil
.Additionally, if the server failed to boot, the status poller would remain in a state of booting.
This meant that it was impossible to boot after an error.
Implementation
This PR moves the creation of the NetAddr into the init method, ensuring it is available from the start.
Additionally, when the server fails to boot, the status poller is now notified that serverBooting is false.
With this PR, users can use the following style (as with SC audio server):
And if it fails, options can be modified and boot called again:
Types of changes
Checklist