Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter disabling max-public-methods with comment doesn't work #222

Closed
madmachinations opened this issue Jul 13, 2023 · 3 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@madmachinations
Copy link

I am trying to disable the max-public-methods rule for a particular file. I am using this comment:

# gdlint: disable=max-public-methods

Using this style of comment seems to disable other checks on this file just fine, but max-public-methods refuses to be disabled by this.

I have tried setting it above all public methods and for the file as a whole.

If I dump the default config and add max-public-methods to the array of disabled things, that works fine. But the comment seems to do nothing.

I believe I am specifying it correctly? I am using V3.5.0

@Scony Scony added the bug Something isn't working label Jul 14, 2023
@Scony Scony added this to the 3.x milestone Jul 14, 2023
@Scony Scony closed this as completed in 61ca00e Jul 14, 2023
@madmachinations
Copy link
Author

This problem is also present for 4.1

@Scony
Copy link
Owner

Scony commented Sep 13, 2023

This is fixed but has not been released yet even tho it's in master already.

@madmachinations
Copy link
Author

Ah, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants