Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust and cargo manifests need updating #97

Closed
analogrelay opened this issue May 30, 2015 · 1 comment · Fixed by #98
Closed

Rust and cargo manifests need updating #97

analogrelay opened this issue May 30, 2015 · 1 comment · Fixed by #98

Comments

@analogrelay
Copy link
Contributor

There are some issues with the rust-nightly and cargo-nightly manifests. Because they generate shim exes, the cargo build tool has trouble shelling out to the rustc compiler (see rust-lang/cargo#1661). Also, cargo is no longer a separate component, it is generally packaged together with rust so having a separate manifest for it is confusing.

I'll be submitting a PR for this momentarily. It's fixed the issue in my environment, but I'll loop in the original submitters of the {rust,cargo}-nightly manifest so they can take a look too.

Scoop-Extras should (and my PR will):

  1. Remove the cargo-nightly manifest, since rustc and cargo are generally installed together from a single MSI
  2. Change from using shims to env_add_path because otherwise Cargo not properly escaping quotes in Windows command lines rust-lang/cargo#1661 gets in the way. I'd still like to track down why the shim isn't working, since I prefer the shim mechanism, but for now this will fix the issue.
@lukesampson
Copy link
Member

Thanks for investigating this Andrew. I wonder if the shim could be fixed by switching shim.cs to use Environment.CommandLine instead of the parsed arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants