-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KakaoTalkAdBlock: Add version 2.1.4 #12968
base: master
Are you sure you want to change the base?
Conversation
All changes look good. Wait for review from human collaborators. kakaotalkadblock
|
/verify |
All changes look good. Wait for review from human collaborators. kakaotalkadblock
|
@oxjihun Please add autoupdate section and 32bit version as well. |
/verify |
All changes look good. Wait for review from human collaborators. kakaotalkadblock
|
/verify |
All changes look good. Wait for review from human collaborators. kakaotalkadblock
|
Virustotal reports a lot of problems: Even if false positive (blurfx/KakaoTalkAdBlock#83, blurfx/KakaoTalkAdBlock#85), guess this could cause problems on installation via scoop, when antivirus blocks installation or quarantines downloaded binaries in case of threat detection. |
@aliesbelik I apologize for making a pull request for a possibly malicious app. To get things straight, I'd have to admit that I was partially aware of this. When writing the manifest for version 2.0.0, Windows Defender's inhibition was the main reason I couldn't include the 32bit version. There was no problem with 64bit version though. Since the program was regionally well known (at least I thought so), I regarded the 64bit version as safe. Never considered of running VirusTotal. And yesterday, when writing the manifest for version 2.1.4, Windows Defender didn't raise any issues for downloading both 32bit and 64bit versions. I vaguely assumed that the false positive got fixed. Therefore, I proceeded to make a second commit. Now I come to think of it, for transparency, I must have elaborated any issues upon opening the pull request. As this is my first time contributing to a large project on GitHub, I am still learning how to contribute 'well'. Though I know this is a mere excuse. I deeply apologize for all this inconvenience. According to blurfx/KakaoTalkAdBlock#85 (comment), the dev managed to get the 2.1.4 version binaries removed from the malware detection list. With this, is there any chance that this manifest could be added to the Extras bucket? Thank you. |
Adds
KakaoTalkAdBlock
(2.0.0) to the bucket.Closes #12883