Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defold: Add version 1.2.170 #4335

Closed
wants to merge 3 commits into from
Closed

defold: Add version 1.2.170 #4335

wants to merge 3 commits into from

Conversation

ftk
Copy link
Contributor

@ftk ftk commented Jun 24, 2020

No description provided.

@Ash258 Ash258 changed the title Defold: Add version 1.2.170 defold: Add version 1.2.170 Jun 24, 2020
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/defold/defold/tree/dev/editor#requirements

Java 11 (installation instructions - Note that we do not yet officially support development with a newer version of Java than 11.
Leiningen (install instructions)

https://github.com/defold/defold/tree/dev/editor#windows

Comment on lines 25 to 31
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/defold/defold/releases/download/$version/beta.editor2.Defold-x86_64-win32.zip"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely not survive next release based on history.

image

image

Manual updates will be better

Suggested change
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/defold/defold/releases/download/$version/beta.editor2.Defold-x86_64-win32.zip"
}
}

bucket/defold.json Outdated Show resolved Hide resolved
bucket/defold.json Outdated Show resolved Hide resolved
@ftk
Copy link
Contributor Author

ftk commented Jun 24, 2020

https://github.com/defold/defold/tree/dev/editor#requirements

Java 11 (installation instructions - Note that we do not yet officially support development with a newer version of Java than 11.
Leiningen (install instructions)

https://github.com/defold/defold/tree/dev/editor#windows

This seems to be instructions for building from source code. The zip archive already contains jdk11.

Changed checkver to https://d.defold.com/stable/ (however zip always has the same filename - issues with scoop cache?)

Also, if there is a way to fake LOCALAPPDATA env var, it could be used for persist

},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/defold/defold/releases/download/$version/beta.editor2.Defold-x86_64-win32.zip"
"url": "$matchUrl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not valid. Use previous version

Comment on lines +25 to +31
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/defold/defold/releases/download/$version/editor-alpha.editor2.Defold-x86_64-win32.zip"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said. Just remove it.

Suggested change
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/defold/defold/releases/download/$version/editor-alpha.editor2.Defold-x86_64-win32.zip"
}
}

@ftk ftk closed this Jun 26, 2020
@anderlli0053 anderlli0053 mentioned this pull request Jan 29, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants