Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgedriver: Update to version 82.0.449.0 (Chromium) #189

Merged
merged 5 commits into from
Mar 20, 2020

Conversation

niheaven
Copy link
Member

Legacy version has been moved to versions.

@Ash258
Copy link
Contributor

Ash258 commented Jun 28, 2019

Edge with chromium is still in development and available for insiders (https://www.microsoftedgeinsider.com/en-us/) I do not think this is good move to replace current version with future version.

@niheaven
Copy link
Member Author

So I put legacy version in version, and add description here to figure out it is Chromium version.

I'll add a note in this manifest.

@Ash258
Copy link
Contributor

Ash258 commented Jun 28, 2019

Yeah, but this should be merged as soon as chromium edge is realease globally as stable for all users and normal edge is retired.

@chawyehsu chawyehsu added upstream Waiting for upstream (the developers of the software) to fix the problem waiting feedback Waiting for user feedback labels Jun 29, 2019
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest looks good.

I just want to block merging until new Edge make it into stable channel

@niheaven
Copy link
Member Author

@Ash258 Edge is now stable: https://www.microsoft.com/en-us/edge

@niheaven niheaven requested a review from Ash258 March 11, 2020 11:48
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test proper functionality, but manifest looks good

@Ash258 Ash258 changed the title edgedriver: Update to Chromium version edgedriver: Update to version 82.0.449.0 (Chromium) Mar 18, 2020
@niheaven niheaven removed upstream Waiting for upstream (the developers of the software) to fix the problem waiting feedback Waiting for user feedback labels Mar 20, 2020
@niheaven niheaven merged commit 4a46902 into ScoopInstaller:master Mar 20, 2020
@niheaven niheaven deleted the update-edgedriver branch April 2, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants