New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cwrsync: Add 6.2.3 #2896
cwrsync: Add 6.2.3 #2896
Conversation
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Personally I am of the opinion that we should try to support the MSYS based rsync instead. And a PR would probably be ready when Scoop can support ZSTD. This rsync flip-flops between paid and free. |
MSYS based rsync is not readily available. Personally I think isolating binaries that depend on msys-2.0.dll isn't a very compatible idea. Besides, I think cwrsync has been free for more than a year now (from when I last used it). The MSYS version shouldn't be a blocker for this anyway. |
/verify |
The package name is what IMHO is a blocker. If this was cwrsync.json on the other hand, I would have no issues because an MSYS based rsync could obtain the rsync.json name. Their Wikipedia article is also titled cwRsync |
I can rename if you prefer. It's fine either way for me |
Okay, let's rename this to cwrsync.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract_dir and incorrect order
@CaselIT hey please run checkver.ps1 offline once |
Thanks for the review, I'll update
I did and it was happy also with the current attribute position. (I copied them from another manifest) In any case I'll update since it seem to make more sense |
done. checkver is also happy:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not modify .gitignore in this PR
Edit: ok, opened another one |
/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manifest looks okay
@rashil2000 uses cwrsync so might know better
for what is worth I've also tried installing it locally by adding the file to the scoop checkout and it did install correctly |
thanks! |
Readds rsync that seem to be again free. It was removed by ScoopInstaller/Scoop@dac9d83 since it was no longer available
Closes #2897