Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwrsync: Add 6.2.3 #2896

Merged
merged 6 commits into from Nov 7, 2021
Merged

cwrsync: Add 6.2.3 #2896

merged 6 commits into from Nov 7, 2021

Conversation

CaselIT
Copy link
Contributor

@CaselIT CaselIT commented Nov 6, 2021

Readds rsync that seem to be again free. It was removed by ScoopInstaller/Scoop@dac9d83 since it was no longer available

Closes #2897

bucket/rsync.json Outdated Show resolved Hide resolved
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
@pratikpc
Copy link
Contributor

pratikpc commented Nov 6, 2021

Personally I am of the opinion that we should try to support the MSYS based rsync instead. And a PR would probably be ready when Scoop can support ZSTD.

This rsync flip-flops between paid and free.

@rashil2000
Copy link
Member

MSYS based rsync is not readily available. Personally I think isolating binaries that depend on msys-2.0.dll isn't a very compatible idea.

Besides, I think cwrsync has been free for more than a year now (from when I last used it). The MSYS version shouldn't be a blocker for this anyway.

@rashil2000
Copy link
Member

/verify

@pratikpc
Copy link
Contributor

pratikpc commented Nov 6, 2021

The MSYS version shouldn't be a blocker for this anyway.

The package name is what IMHO is a blocker.

If this was cwrsync.json on the other hand, I would have no issues because an MSYS based rsync could obtain the rsync.json name.

Their Wikipedia article is also titled cwRsync

@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 6, 2021

I can rename if you prefer. It's fine either way for me

bucket/rsync.json Outdated Show resolved Hide resolved
bucket/rsync.json Outdated Show resolved Hide resolved
@rashil2000
Copy link
Member

Okay, let's rename this to cwrsync.json

bucket/rsync.json Outdated Show resolved Hide resolved
Copy link
Contributor

@pratikpc pratikpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract_dir and incorrect order

bucket/rsync.json Outdated Show resolved Hide resolved
@pratikpc
Copy link
Contributor

pratikpc commented Nov 6, 2021

@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 6, 2021

Thanks for the review, I'll update

@CaselIT hey please run checkver.ps1 offline once

https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate#using-checkverps1-to-query-and-autoupdate

I did and it was happy also with the current attribute position. (I copied them from another manifest)

In any case I'll update since it seem to make more sense

@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 6, 2021

done. checkver is also happy:

cwrsync: 6.2.3 (scoop version is 6.2.2) autoupdate available
Autoupdating cwrsync
Searching hash for cwrsync_6.2.3_x64_free.zip in https://itefix.net/dl/free-software/cwrsync_6.2.3_x64_free.zip.sha256.asc
Found: 19356b4910e587a158b3cffb1aa4cb6a942826b5727d97522ff9ee5f97236158 using Extract Mode
Writing updated cwrsync manifest

.gitignore Outdated Show resolved Hide resolved
bucket/cwrsync.json Outdated Show resolved Hide resolved
@pratikpc pratikpc changed the title readd rsync. cwrsync: Add 6.2.3 Nov 6, 2021
@CaselIT CaselIT requested a review from pratikpc November 6, 2021 19:27
Copy link
Contributor

@pratikpc pratikpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not modify .gitignore in this PR

@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 6, 2021

Please do not modify .gitignore in this PR

Edit: ok, opened another one

@CaselIT CaselIT requested a review from pratikpc November 6, 2021 19:34
@pratikpc
Copy link
Contributor

pratikpc commented Nov 6, 2021

/verify

Copy link
Contributor

@pratikpc pratikpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest looks okay

@rashil2000 uses cwrsync so might know better

@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 7, 2021

for what is worth I've also tried installing it locally by adding the file to the scoop checkout and it did install correctly

@rashil2000 rashil2000 merged commit f04f019 into ScoopInstaller:master Nov 7, 2021
@CaselIT
Copy link
Contributor Author

CaselIT commented Nov 7, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free rsync client is available again
3 participants