Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize: update to latest version #471

Merged
merged 2 commits into from
Oct 21, 2019
Merged

kustomize: update to latest version #471

merged 2 commits into from
Oct 21, 2019

Conversation

kungfutse
Copy link
Contributor

No description provided.

Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You completely break the whole manifest.

Fixed manifest
{
    "homepage": "https://github.com/kubernetes-sigs/kustomize",
    "description": "Customize raw, template-free YAML files for multiple purposes, leaving the original YAML untouched and usable as is.",
    "license": "Apache-2.0",
    "version": "3.2.1",
    "architecture": {
        "64bit": {
            "url": "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv3.2.1/kustomize_kustomize.v3.2.1_windows_amd64.exe#/kustomize.exe",
            "hash": "73b0dbc3457d48717628ceea65dc3f1ee9b51b41cdeb4d70c793374446b3e6b1"
        }
    },
    "bin": "kustomize.exe",
    "checkver": {
        "github": "https://github.com/kubernetes-sigs/kustomize",
        "regex": "kustomize/v([\\d.]+)"
    },
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv$version/kustomize_kustomize.v$version_windows_amd64.exe#/kustomize.exe"
            }
        },
        "hash": {
            "url": "$baseurl/checksums.txt",
            "regex": "$sha256\\s+kustomize_kustomize/v$version_windows_amd64.exe"
        }
    }
}

@kungfutse kungfutse requested a review from Ash258 October 8, 2019 06:31
@Ash258
Copy link
Contributor

Ash258 commented Oct 8, 2019

I do not know if there will be only kustomize releases tagged as latest, but with this weird release process i think latest could be flanky and cause Excavator trying to match non existent releases

Right now there are two newer releases (pluginator, go api), which are not tagged as latest. It could be kept this way or using this checkver to really match only kustomize releases:

    "checkver": {
          "url": "...kustomize/releases",
          "regex": "tree/kustomize/v([\\d.]+)"
   },

Copy link
Contributor Author

@kungfutse kungfutse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the manifest. Didn't touch the auto-update logic further

@rasa
Copy link
Member

rasa commented Oct 11, 2019

See #150

@r15ch13 r15ch13 merged commit 866f73c into ScoopInstaller:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants