Add support for *_HOME variables in rustup. #5015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify |
|
All changes look good. Wait for review from human collaborators. rustup
|
|
Hi @marknefedov! Why did you close? |
|
In the issue it have been suggested to move to a separate manifest, and
apparently the last command in the post install script is unreliable, or it
is my windows installation being finicky. Feel free to use as a base though.
…On Fri, 11 Aug 2023, 15:38 Rashil Gandhi, ***@***.***> wrote:
Hi @marknefedov <https://github.com/marknefedov>!
Why did you close?
—
Reply to this email directly, view it on GitHub
<#5015 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYTEC3VYTQEJEP4FLCWWWLXUYRV3ANCNFSM6AAAAAA3LG5ZTE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
brian6932
suggested changes
Dec 1, 2023
Co-authored-by: Brian <18603393+brian6932@users.noreply.github.com>
|
I keep my opinion that Scoop should manage the environment variables of Apps as possible. If other maintainers would like to merge it, feel free to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set CARGO_HOME and RUSTUP_HOME environment variables if not set already.
If vars are set, install to those location.
Closes #5013