Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winpython: Switch to full distribution #523

Merged
merged 4 commits into from
Jan 8, 2020
Merged

winpython: Switch to full distribution #523

merged 4 commits into from
Jan 8, 2020

Conversation

rasa
Copy link
Member

@rasa rasa commented Oct 31, 2019

Copy link
Contributor

@linsui linsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zero version and dot version binaries are 20M+ but the full version binaries are 400M+. So I wonder should we change to the full version?

bucket/winpython.json Outdated Show resolved Hide resolved
bucket/winpython.json Outdated Show resolved Hide resolved
@niheaven
Copy link
Member

niheaven commented Oct 31, 2019

Zero version ('dot' for 3.8) is better.

@rasa
Copy link
Member Author

rasa commented Oct 31, 2019

Per https://github.com/winpython/winpython/releases, perhaps winpython is the full 414MB+ version, and we add a new winpython-dot that is the 21MB+ version:

    "checkver": {
        "github": "https://github.com/winpython/winpython/",
        "regex": "-([\\d.]+)dot\\.exe",
        "reverse": true
    },
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://downloads.sourceforge.net/project/winpython/WinPython_$majorVersion.$minorVersion/$version/WinPython64-${version}dot.exe#/dl.7z",
                "extract_dir": "WPy64-$cleanVersion\\python-$majorVersion.$minorVersion.$patchVersion.amd64"
            },
            "32bit": {
                "url": "https://downloads.sourceforge.net/project/winpython/WinPython_$majorVersion.$minorVersion/$version/WinPython32-${version}dot.exe#/dl.7z",
                "extract_dir": "WPy32-$cleanVersion\\python-$majorVersion.$minorVersion.$patchVersion"
            }
        },

@niheaven
Copy link
Member

niheaven commented Nov 1, 2019

We have python, why use WinPython as just another python dist? This two dist is identical, except for some Python library.

Using full WinPython dist, porting and using all WinPython's tools are much better.

PS: WinPython-dot (or Zero) is just package that should overwrite existed dist for updating.

@rasa
Copy link
Member Author

rasa commented Dec 3, 2019

Please vote on if we should:

  1. Fix this package (thumbs up)
  2. Remove this package (thumbs down)
  3. Fix it, but move it to versions, as it essentially duplicates an existing package. (rocket ship)

@niheaven
Copy link
Member

niheaven commented Dec 4, 2019

Fix it, but as a full python dist, i.e., using full release, porting all exes, etc.

No need to use it as another pure python dist.

@chawyehsu
Copy link
Member

vote for full dist only.

@niheaven
Copy link
Member

niheaven commented Jan 7, 2020

I've updated winpython to full dist, and added usefull bins and shortcuts. Other versions (e.g. Ps2 or cod) are submitted to versions bucket. (ScoopInstaller/Versions#194)

Ping @rasa @h404bi @Ash258

Copy link
Member Author

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can't approve or merge.

@StormPooper
Copy link

Tried this locally and I get (404) Not Found, same as on master - see #688.

SF's link is case sensitive
@niheaven
Copy link
Member

niheaven commented Jan 7, 2020

@StormPooper Please try again.

@StormPooper
Copy link

@niheaven looks to be working, currently downloading. Thanks 👍

@StormPooper
Copy link

One thing I've noticed with this version is that my Python scripts are no longer directly accessible from the command line.

I think the environment variables are wrong, PYTHONPATH resolves to %PY_HOME%\Lib;%PY_HOME%\DLLs;%PY_HOME%\Lib\lib-tk, with PY_HOME being %SCOOP%\apps\winpython\current.

The problem is that the paths in PYTHONPATH actually live in %PY_HOME%\python-3.8.1.amd64\<whatever>, so even if I were to add %PY_HOME\Scripts to my path it wouldn't resolve correctly.

@niheaven
Copy link
Member

niheaven commented Jan 7, 2020

I just port everything that WinPython dist has. You may need to run the script in WinPython Prompt, or run winpython_prompt from cli first...

@StormPooper
Copy link

StormPooper commented Jan 7, 2020

Thanks, added winpython_prompt.ps1 to my PowerShell startup script and it works. Edit: Breaks git, so I'm reverting it. Would be nice if the installation script set WINPYDIR to be %PYHOME%\python-<version>.<arch>.

@niheaven niheaven changed the title winpython: fix aus winpython: Switch to full distribution Jan 8, 2020
@niheaven niheaven merged commit 4332925 into master Jan 8, 2020
@niheaven niheaven deleted the rasa-winpython branch January 8, 2020 07:18
@niheaven
Copy link
Member

niheaven commented Jan 8, 2020

scripts\env.bat set enviroment variables (include %HOME%, which breaks git). WinPython_PS_Prompt.ps1 does the same thing under PowerShell...

What I mean is run winpython_prompt.ps1 before your script, this one doesn't affect any system settings, just likes original WinPython installation. I don't know why Winpython set %HOME% to %WINPYDIRBASE%\settings, any software that sets %HOME% is not user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

winpython@3.8.1.0: download via aria2 failed winpython@3.8.1.0: invalid download url
6 participants