-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: Fix environment variables #5336
Conversation
slpro no longer handles /lib for you, `pre_install` required Added OPENSSL_ROOT_DIR
4ee2c82
to
c2e4e94
Compare
/verify |
All changes look good. Wait for review from human collaborators. openssl
|
symlink creation require admin right, so I reverted the scripts. |
Not anymore @HUMORCE only old versions of Windows https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/ |
#5361 is related to powershell 5 compatibility only. missing For symlinks creation, I don't remember too clearly. but symlink cannot be created with
|
While this issue is a thing PowerShell/PowerShell#7967
❯ powershell.exe -NoProfile
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.
Try the new cross-platform PowerShell https://aka.ms/pscore6
PS > $PSVersionTable
Name Value
---- -----
PSVersion 5.1.19041.3693
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.19041.3693
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
PS > Get-ChildItem | Get-Member Name
TypeName: System.IO.DirectoryInfo
Name MemberType Definition
---- ---------- ----------
Name Property string Name {get;}
TypeName: System.IO.FileInfo
Name MemberType Definition
---- ---------- ----------
Name Property string Name {get;}
PS > Get-ChildItem | Get-Member FullName
TypeName: System.IO.DirectoryInfo
Name MemberType Definition
---- ---------- ----------
FullName Property string FullName {get;}
TypeName: System.IO.FileInfo
Name MemberType Definition
---- ---------- ----------
FullName Property string FullName {get;} @babinskiy Please test #5372 if you can |
… (Close ScoopInstaller#5361)" This reverts commit dea5d39.
slpro no longer handles /lib for you,
pre_install
requiredI had a discussion with the maintainer, and they mentioned they no longer wanted to handle this
Quote from email exchanges:
Added
OPENSSL_ROOT_DIR
, now works with cmake OOTB