Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: Fix environment variables #5336

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Dec 8, 2023

slpro no longer handles /lib for you, pre_install required

I had a discussion with the maintainer, and they mentioned they no longer wanted to handle this
Quote from email exchanges:

Starting with 3.2.0, a new build/package/deploy system is being used
because I was starting to go insane due to the regular barrage of
upstream releases. The new system will be used going forward for ALL
releases - including the next 3.0.x and 3.1.x. As part of this change,
the 'lib' directory structure was completely redone.

Added OPENSSL_ROOT_DIR, now works with cmake OOTB

slpro no longer handles /lib for you, `pre_install` required
Added OPENSSL_ROOT_DIR
@brian6932
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Dec 8, 2023

All changes look good.

Wait for review from human collaborators.

openssl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@HUMORCE HUMORCE merged commit 62cf167 into ScoopInstaller:master Dec 9, 2023
2 checks passed
HUMORCE added a commit that referenced this pull request Dec 22, 2023
- Symlink creataion requires admin right.
@HUMORCE
Copy link
Member

HUMORCE commented Dec 22, 2023

symlink creation require admin right, so I reverted the scripts.

@brian6932
Copy link
Contributor Author

brian6932 commented Dec 23, 2023

Not anymore @HUMORCE only old versions of Windows https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/
Issue seems to be PowerShell 5 related(?)
Wish the tests picked it up, I'll look into it when I get the chance

@HUMORCE
Copy link
Member

HUMORCE commented Dec 23, 2023

Issue seems to be PowerShell 5 related(?)

#5361 is related to powershell 5 compatibility only. missing FullName prop.

For symlinks creation, I don't remember too clearly. but symlink cannot be created with new-item ... in powershell 5 even developer mode are enabled. but dev mode can solves issue like #5357

> scoop checkup
...
WARN  Windows Developer Mode is not enabled. Operations relevant to symlinks may fail without proper rights.
  You may read more about the symlinks support here:
  https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/
...

@brian6932
Copy link
Contributor Author

brian6932 commented Dec 23, 2023

While this issue is a thing PowerShell/PowerShell#7967
SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE is both within the enum and implemented within WinCreateSymbolicLink(), so not sure why it wouldn't work (outside of PowerShell 5).
I guess I can re-PR with a DllImport on builds >= 14972, and/or potentially add such a function to Scoop itself, could be pretty useful.

#5361 is related to powershell 5 compatibility only. missing FullName prop.

FullName wasn't used Name was, either way both are available in PowerShell 5. The reason for the incompatibility was due to PowerShell 5's ToString() method. It uses Name instead of FullName, easy to solve, just have to be explicit with the property.

powershell.exe -NoProfile
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

PS > $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.3693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.3693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1


PS > Get-ChildItem | Get-Member Name


   TypeName: System.IO.DirectoryInfo

Name MemberType Definition
---- ---------- ----------
Name Property   string Name {get;}


   TypeName: System.IO.FileInfo

Name MemberType Definition
---- ---------- ----------
Name Property   string Name {get;}


PS > Get-ChildItem | Get-Member FullName


   TypeName: System.IO.DirectoryInfo

Name     MemberType Definition
----     ---------- ----------
FullName Property   string FullName {get;}


   TypeName: System.IO.FileInfo

Name     MemberType Definition
----     ---------- ----------
FullName Property   string FullName {get;}

@babinskiy Please test #5372 if you can

brian6932 added a commit to brian6932/Main that referenced this pull request Dec 23, 2023
HUMORCE pushed a commit that referenced this pull request Dec 26, 2023
* Revert "openssl@3.2.0: Revert scripts introduced in #5336 (Close #5361)"

This reverts commit dea5d39.

* openssl: Fix environment variables (2)

* openssl: Use job to isolate type scope
prevents the creation of `[Microsoft.PowerShell.Commands.AddType.AutoGeneratedTypes._]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants