search: better handling for invalid query (fixes #634

ScoopInstaller · Jan 14, 2016 · bf02470 · bf02470
1 parent c98e8b6
commit bf02470
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/libexec/scoop-search.ps1 b/libexec/scoop-search.ps1
@@ -29,13 +29,21 @@ function search_bucket($bucket, $query) {
         @{ name = $_ }
     }
 
-    if($query) { $apps = $apps | ? {
-        if($_.name -match $query) { return $true }
-        $bin = bin_match (manifest $_.name $bucket) $query
-        if($bin) {
-            $_.bin = $bin; return $true;
+    if($query) {
+        try {
+            $query = new-object regex $query
+        } catch {
+            abort "invalid regular expression: $($_.exception.innerexception.message)"
         }
-    } }
+
+        $apps = $apps | ? {
+            if($_.name -match $query) { return $true }
+            $bin = bin_match (manifest $_.name $bucket) $query
+            if($bin) {
+                $_.bin = $bin; return $true;
+            }
+        }
+    }
     $apps | % { $_.version = (latest_version $_.name $bucket); $_ }
 }