refactor(core): Get rid of 'fullpath' #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash258
suggested changes
Jun 27, 2019
|
Removed |
niheaven
force-pushed
the
remove-fullpath
branch
from
c941963
to
d542434
Compare
Ash258
suggested changes
Jul 20, 2019
Ash258
suggested changes
Nov 8, 2019
Ash258
reviewed
Nov 11, 2019
Ash258
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
Whole codebase is using lowcased keywords. Do not see a reason to add additional inconsistency.
https://github.com/lukesampson/scoop/search?l=PowerShell&q=param
10 tasks
|
This will break Excavator due to path glueing with hardcoded backslash.
|
21 tasks
niheaven
force-pushed
the
remove-fullpath
branch
from
efc8ddb
to
65ac47c
Compare
niheaven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
fullpath, just get absolute path when initialing$globaldir,$scoopdirand$cachedir, other dirs are derived from these three root ones.