Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Bump to version 0.4.0 #5424

Merged
merged 75 commits into from
Apr 18, 2024
Merged

chore(release): Bump to version 0.4.0 #5424

merged 75 commits into from
Apr 18, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Mar 10, 2023

Changelog

Features

Bug Fixes

Performance Improvements

Code Refactoring

Builds

Continuous Integration

Tests

Documentation

Close Issues

Credits

Thanks to the following contributors (ordered by PR merging time):

@r15ch13 @niheaven @HUMORCE @rashil2000 @rasa @Ercolino @jeppefrandsen @chawyehsu @WHYBBE @Valinor @starthal @lewis-yeung @Lutra-Fs @walpox @spider2048 @gerardog @dooptydoo90x @hagaigold @davidlwatsonjr @svraka @amorphobia

r15ch13 and others added 18 commits November 23, 2022 13:58
* fix(chore): Handle spaces in git command arguments

* changelog

* Use splatting
…sitories (#5361)

Fix download from private GitHub repos
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
…xplicit arguments type (#5326)

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
…ormance (#5410)

See: ScoopInstaller/Install#42

---------

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@chawyehsu
Copy link
Member

FYI, it's urgent that #???? (fix for #5065) and #5346 (fix for #5066) have to be included in this release otherwise the regression would last for a longer time until the next release cycle.

@niheaven
Copy link
Member Author

Oh yes, so waiting for them. I'll prepare for #5065 these two days.

@lewis-yeung
Copy link
Contributor

Opps! I forgot to change the title of #5346 before it got merged. 😅

@WHYBBE
Copy link
Contributor

WHYBBE commented Mar 22, 2023

There are some issues related to ScoopInstaller/Install#48, due to my two modifications: ScoopInstaller/Install#44 and #5395

An easily reproducible case is:

  • Use the latest dev branch code(New method to get/set env in core.ps1)
  • Install a python version that has not been installed by scoop(There is no relevant Python path in environment variables)
  • Execute python --version(The correct version can be obtained)
  • Right-click to open the Windows start key, select Windows Terminal(Windows 11)
  • Execute python --version again(Can't get the version correctly)
  • It can also be verified by directly adding a script or executable program to the Python environment variable path that was just added and repeating the above steps

The code I modified caused a little problem with the environment variable session. If you pin a Windows Terminal on the taskbar and use it to open Powershell, the problem will be covered up.

What I said may not be intuitive, anyway, my ScoopInstaller/Install#44 and #5395 modifications have some problems that need to be fixed.

A more detailed description can be found in comment-1479699208

@niheaven
Copy link
Member Author

So the new method add path to current session only? Could you have a hotfix for it?

@WHYBBE
Copy link
Contributor

WHYBBE commented Mar 22, 2023

So the new method add path to current session only? Could you have a hotfix for it?

No, the situation is very complicated. The modification of the registry is successful, and of course the modification of the Path is also successful, but the strange thing is that the session will not be modified in some cases at some places.

Return to normal by doing some operations: Restart or manually save the editor of Path once (open Path and save it, no need to modify). Of course this is not acceptable.

However I don't know how to deal with it, and I have a busy weekday, maybe I can spend the weekend exploring what is wrong.

I apologize for the new bugs(shouldn't exist) I caused.

@r15ch13
Copy link
Member

r15ch13 commented Mar 22, 2023

Changing the registry value is not enough.
This is why choco runs setx and calls a user32.dll function:
https://github.com/chocolatey/choco/blob/ac806ee5ce03dea28f01c81f88c30c17726cb3e9/src/chocolatey.resources/helpers/functions/Set-EnvironmentVariable.ps1#L99-L124
The function call is probably not needed, because we don't care what explorer.exe does.

Copy of ScoopInstaller/Install#48 (comment)

@niheaven niheaven changed the title chore(release): Bump to version 0.3.2 chore(release): Bump to version 0.4.0 Mar 22, 2024
@29039
Copy link

29039 commented Mar 23, 2024

Hey all, I have been using/customising scoop to my needs, I want to contribute a few tweaks upstream.

Just wondering,

1: what is the anticipated release date of 0.4.0 is it too late to submit new changes?

2: How can I install 0.4.0 for testing?

@(
"@rem $resolved_path",
"@`"$(Join-Path (Join-Path $gitdir.FullName 'bin') 'bash.exe')`" `"$resolved_path`" $arg %*"
"@bash `"$resolved_path`" $arg %*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niheaven niheaven marked this pull request as ready for review April 18, 2024 12:05
@niheaven niheaven requested a review from a team April 18, 2024 12:06
rashil2000
rashil2000 approved these changes Apr 18, 2024
@niheaven niheaven merged commit 105e416 into master Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment