Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoupdate): Decode basename when extract hash #3615

Merged
merged 1 commit into from
Oct 14, 2019
Merged

fix(autoupdate): Decode basename when extract hash #3615

merged 1 commit into from
Oct 14, 2019

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Aug 29, 2019 •
edited
Loading

Firefox, Thunderbird and uget can benefit.

@Ash258
Copy link
Contributor

Ash258 commented Aug 29, 2019 •
edited
Loading

What does have basename string to do with hash extraction templates?? Do not add it into hash templates

https://github.com/lukesampson/scoop/blob/79f8538b57b9021db71a279879b9032fefd1ae52/lib/autoupdate.ps1#L180

@linsui
Copy link
Contributor Author

linsui commented Aug 29, 2019

substitutions will be regexEscape.

https://github.com/lukesampson/scoop/blob/79f8538b57b9021db71a279879b9032fefd1ae52/lib/autoupdate.ps1#L58

@linsui linsui changed the title feat(autoupdate): match basename with space feat(autoupdate): match basename with space and + Aug 29, 2019
@Ash258
Copy link
Contributor

Ash258 commented Oct 12, 2019

Would not be more suitable to url decode it rather than specifiing all possible escapes?

[System.Web.HttpUtility]::UrlDecode('uget-2.2.2-win32%2Bgtk3.7z')

image

Relate ScoopInstaller/Main#471

@linsui
Copy link
Contributor Author

linsui commented Oct 13, 2019

Good idea! Would you pr? Then I'll close this.

@chawyehsu
Copy link
Member

Good idea! Would you pr? Then I'll close this.

Why not update your pull request?

@linsui
Copy link
Contributor Author

linsui commented Oct 13, 2019

I don't want to steal credit 😂 . If @Ash258 doesn't want to open another pr I'm glad to update this.

@chawyehsu
Copy link
Member

I don't want to steal credit 😂 . If @Ash258 doesn't want to open another pr I'm glad to update this.

You can commit withCo-authored-by like this

@linsui
Copy link
Contributor Author

linsui commented Oct 13, 2019

Thanks! I'll have a try.

@Ash258
Copy link
Contributor

Ash258 commented Oct 13, 2019

I do not care for contributions. Edit this PR.

@linsui linsui closed this Oct 13, 2019
@Ash258
fix(autoupdate): Decode basename when extract hash
81d5aa7 
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
@linsui linsui mentioned this pull request Oct 13, 2019
Closed
@linsui linsui reopened this Oct 13, 2019
@linsui linsui changed the title feat(autoupdate): match basename with space and + fix(autoupdate): Decode basename when extract hash Oct 13, 2019
@r15ch13 r15ch13 merged commit 19ed5e4 into ScoopInstaller:develop Oct 14, 2019
@linsui linsui deleted the basename branch October 14, 2019 12:28
@linsui linsui mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linsui @Ash258 @chawyehsu @r15ch13