Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hash): Use 'Get-FileHash()' directly #5177

Merged
merged 2 commits into from
Oct 13, 2022
Merged

refactor(hash): Use 'Get-FileHash()' directly #5177

merged 2 commits into from
Oct 13, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Oct 10, 2022 •
edited
Loading

Description

PowerShell 5 and later have Get-FileHash() and we could use it directly.

Motivation and Context

Simplify code base.

How Has This Been Tested?

scoop install and checkver

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit 24301ac into develop Oct 13, 2022
@niheaven niheaven deleted the remove-compute-hash branch October 13, 2022 11:15
github-actions bot pushed a commit to pukkandan/Scoop that referenced this pull request Oct 20, 2022
@niheaven @github-actions
refactor(hash): Use 'Get-FileHash()' directly (ScoopInstaller#5177)
d4e6319
@niheaven niheaven mentioned this pull request Nov 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000