Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shim): Avoid unexpected output of list subcommand #5681

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

lewis-yeung
Copy link
Contributor

Description

Related: #5568. See my comment.

The usage of scoop shim list should be more explicit: scoop shim list [<shim_name>/<regex_pattern>...], since regular expression matching is used in this case.

Motivation and Context

Closes #5568.

How Has This Been Tested?

Run:

scoop shim list scoo*

Output:

Name       Source   Alternatives IsGlobal IsHidden
----       ------   ------------ -------- --------
scoop-slim External              False    False
scoop      scoop                 False    False

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

libexec/scoop-shim.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@rashil2000 rashil2000 merged commit 2847e0a into ScoopInstaller:develop Oct 10, 2023
2 checks passed
@lewis-yeung lewis-yeung deleted the fix-shim-list branch October 10, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants