Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Extraction OperationStopped: regression from #5973 or #5951 #5982

Closed
brian6932 opened this issue May 20, 2024 · 6 comments
Closed

[Bug] Extraction OperationStopped: regression from #5973 or #5951 #5982

brian6932 opened this issue May 20, 2024 · 6 comments
Labels

Comments

@brian6932
Copy link

brian6932 commented May 20, 2024

Bug Report

Current Behavior

scoop install $($_ = 'test'; '{"version":"nightly","architecture":{"64bit":{"url":"https://secure-appldnld.apple.com/itunes12/052-51516-20240506-351B8BFB-C5A7-4FD8-8262-60CD9FAA1464/iTunes64Setup.exe#/_.zip"}}}' > $_; $_)
WARN  This is a nightly version. Downloaded files won't be verified.
Installing 'test' (nightly-20240520) [64bit] from '~\test'
Extracting iTunes64Setup.exe ...
GAC    Version        Location
---    -------        --------
False  v4.0.30319     ~\scoop\apps\pwsh-beta\current\WindowsBase.dll
OperationStopped:

Expected Behavior

Extract-7zipArchive used to work fine. Likely caused by #5973 or #5951.

System details

Windows version: 10

OS architecture: 64bit

PowerShell version: 7.5.0-preview.2

Additional software:

❯ scoop.ps1 list 7zip-beta
Installed apps matching '7zip-beta':

Name      Version Source   Updated             Info
----      ------- ------   -------             ----
7zip-beta 24.05   versions 2024-05-15 09:22:57 64bit

Scoop Configuration

{
  "alias": {},
  "debug": true,
  "cat_style": "full",
  "aria2-warning-enabled": false,
  "aria2-max-connection-per-server": "16",
  "aria2-min-split-size": "1M",
  "aria2-split": "64",
  "aria2-options": "--no-conf=false",
  "last_update": "2024-05-20T13:55:23.7586392-04:00",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop",
  "scoop_branch": "develop",
  "use_lessmsi": true,
  "use_external_7zip": true,
  "use_sqlite_cache": true
}
@brian6932 brian6932 added the bug label May 20, 2024
@brian6932 brian6932 changed the title [Bug] Extraction OperationStopped: regression from #5973 [Bug] Extraction OperationStopped: regression from #5973 or #5951 May 20, 2024
@niheaven
Copy link
Member

Could not reproduce here, what's the 7zip log?

@brian6932
Copy link
Author

brian6932 commented May 21, 2024

There's no log file in the dir

❯ ls ~\scoop\apps\test\nightly-20240521

        Directory:
    ~\scoop\apps\test\nightly-20240521


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a---        2024-05-06   6:34 PM      211265904   _.zip

After another look, I noticed that this only occurs when the file extension's renamed to .zip, .7z works as expected.

@niheaven
Copy link
Member

niheaven commented May 21, 2024

The extractor choosing function is not changed, and both Expand-7zipArchive() and Expand-ZipArchive() should extract the zip file. Is there an error in PS5 or main branch?

@niheaven
Copy link
Member

And is there any error when installing other zip archives, e.g., ag?

@brian6932
Copy link
Author

brian6932 commented May 21, 2024

Is there an error in PS5 or main branch?

Doesn't happen on the master branch.

❯ $Error
OperationStopped:

New-Object: Exception calling ".ctor" with "3" argument(s): "End of Central Directory record could not be found."

And is there any error when installing other zip archives, e.g., ag?

Haven't seen any so far, I've only updated my branch for a day so far.

@niheaven
Copy link
Member

Ref: https://stackoverflow.com/a/20960434

Since the archive is indeed a CAB file, Expand-ZipArchive() encountered this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants