Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(decompress): Use 7zip to extract Zstd archive #5973

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 16, 2024

Description

Since 7zip has supported ZSTD archives from version 24.05, the Expand-ZstdArchive() function can be removed.

Motivation and Context

Ref: https://github.com/ip7z/7zip/releases/tag/24.05

How Has This Been Tested?

Pass all tests. Tested with scoop install aspell.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit 5c896e9 into develop May 17, 2024
2 checks passed
@niheaven niheaven deleted the refactor-zstd branch May 17, 2024 01:56
@chawyehsu
Copy link
Member

You're assuming all users have upgraded 7zip to v24....

scoop install luajit
Installing 'luajit' (2.1.1713773202-1) [64bit] from 'main' bucket
Loading mingw-w64-x86_64-luajit-2.1.1713773202-1-any.pkg.tar.zst from cache
Checking hash of mingw-w64-x86_64-luajit-2.1.1713773202-1-any.pkg.tar.zst ... ok.
Extracting mingw-w64-x86_64-luajit-2.1.1713773202-1-any.pkg.tar.zst ... ERROR Exit code was 2!
Failed to extract files from [...]\scoop\apps\luajit\2.1.1713773202-1\mingw-w64-x86_64-luajit-2.1.1713773202-1-any.pkg.tar.zst.
Log file:
  ~\scoop\apps\luajit\2.1.1713773202-1\7zip.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Main/issues/new?title=luajit%402.1.1713773202-1%3a+decompress+error

@niheaven
Copy link
Member Author

Hmm, some users locked their 7zip version? Since 7zip is updated to 24.05 for two days now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants