Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist cache #1537

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Persist cache #1537

merged 2 commits into from
Jun 1, 2017

Conversation

nueko
Copy link
Contributor

@nueko nueko commented Jun 1, 2017

No description provided.

@r15ch13
Copy link
Member

r15ch13 commented Jun 1, 2017

This is more clear: `"post_install": "yarn config set cache "$persist_dir\cache","

The note will not work if npm isn't installed. Also yarn adds global binaries to %LOCALAPPDATA%\Yarn\bin.

yarn config set prefix \"$persist_dir\\bin\" as post_install could work, but I think adding %LOCALAPPDATA%\Yarn\bin to the PATH might be a better idea.

@nueko
Copy link
Contributor Author

nueko commented Jun 1, 2017

%LOCALAPPDATA%\Yarn\bin to the PATH might be a better idea.

Agree!

The note will not work if npm isn't installed. Also yarn adds global binaries to %LOCALAPPDATA%\Yarn\bin.

That's why it just a note, yarn global bin will set to the npm global bin if we set the prefix to yarn config

capture

@r15ch13
Copy link
Member

r15ch13 commented Jun 1, 2017

If we add the global bin to PATH, then we don't need the note.

@nueko
Copy link
Contributor Author

nueko commented Jun 1, 2017

Can You tweak it, mate? I have to sahur right now.

@r15ch13
Copy link
Member

r15ch13 commented Jun 1, 2017

Yep

@nueko
Copy link
Contributor Author

nueko commented Jun 1, 2017

Wouldn't it be better to merge the global packages that installed by both npm and yarn?

@r15ch13
Copy link
Member

r15ch13 commented Jun 1, 2017

In which way would this be better? I think it is more confusing.

@nueko
Copy link
Contributor Author

nueko commented Jun 1, 2017

Ah, nevermind.
That's user choice.
I think that's enough

@r15ch13 r15ch13 merged commit e4cc2c3 into ScoopInstaller:master Jun 1, 2017
@nueko nueko deleted the patch-5 branch June 1, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants