-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Prepare extraction of main bucket #3060
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0e36c8f
Add main bucket into buckets
Ash258 9c52f84
Download main bucket on installing
Ash258 ab52591
Some duplicated code 🤔
Ash258 147d49b
Check for branch update
Ash258 c00c0a1
Add checkup for main bucket
Ash258 fe87318
Move buckets functions from lib-exec into lib
Ash258 a7a7431
pre-create folder structure
Ash258 7d7facd
Revert pre-creating
Ash258 ec524cf
udpate: don't call scoop, but use get(set)_config functions
Ash258 9ec0897
update: Add main bucket if there is not
Ash258 2f16f0d
Make main bucket default
Ash258 120d79e
Should be all?
Ash258 273b735
Install from my concept
Ash258 4240955
Adress main bucket update problem
Ash258 4d5988b
Merge branch 'master' into new-master
Ash258 e83ffda
Merge master
Ash258 972e418
Spaces
Ash258 3d83643
Some last changes to handle bucket extraction
Ash258 72847c8
Adopt binaries
Ash258 5446e8e
bucketdir -> Find-BucketDirectory
Ash258 0ec7ab9
Full implement extraction progress
Ash258 74b20aa
Merge branch 'master' of https://github.com/lukesampson/scoop into ne…
Ash258 d8c75e4
Typo
Ash258 83884f8
Remove redundant .vscode settings
Ash258 a5dd6b1
fix merge error
Ash258 1187dfc
missing imports
Ash258 8b97370
fix(info): Shows wrong URL to manifest
Ash258 cfd628c
Load known_buckets from $psscriptroot
Ash258 bdcf946
Ignore [main] bucket message in list command
Ash258 8c8e872
Fix update always add and remove main bucket
Ash258 58eb7ec
Move comment to correct line
Ash258 d1fa838
fix(install.ps1): PR @niheaven
Ash258 d9a3d59
Leave binaries params empty, mark them mandatory
Ash258 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
version: '3.6' | ||
|
||
services: | ||
scoop: | ||
image: microsoft/windowsservercore:1803 | ||
container_name: scoop_debug | ||
command: powershell.exe -NoLogo -NoExit | ||
working_dir: C:\SCOOP\apps\scoop\current\bin | ||
environment: | ||
SCOOP: C:\SCOOP | ||
SCOOP_HOME: C:\SCOOP\apps\scoop\current | ||
volumes: | ||
- .:C:\SCOOP\apps\scoop\current |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest leave hash mode comment for illustrations, there is something
TODO
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All are already implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean
TODO
more, and leave these implemented alone as comment. Maybe need to rearrange these lines.