Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show manifest on installation #4155

Merged
merged 3 commits into from Dec 8, 2021
Merged

Show manifest on installation #4155

merged 3 commits into from Dec 8, 2021

Conversation

MrNuggelz
Copy link
Contributor

@MrNuggelz MrNuggelz commented Oct 28, 2020 •
edited

Closes #2735

@rashil2000
Copy link
Member

rashil2000 commented Nov 19, 2021 •
edited

I think a better and more granular approach would be implementing something like #4272. This would allow users to view manifests even when they aren't installing an app. Would you like to work on it?

@MrNuggelz
Copy link
Contributor Author

The use case for this pull request is so you can review the manifest before updating an app, similar to what many AUR helpers.
This is especially usefull for third party buckets, were manifests are less monitored.
I additionally created a pull request for a cat command like it was proposed in the pull request you mentioned, see: #4532

rashil2000
rashil2000 requested changes Nov 24, 2021
View reviewed changes
lib/install.ps1 Outdated Show resolved Hide resolved
lib/install.ps1 Outdated Show resolved Hide resolved
@issaclin32
Copy link
Member

I think it won't hurt to add this small feature, even if I personally prefer to use scoop cat to check first.

@niheaven
Copy link
Member

niheaven commented Dec 2, 2021

Don't annoy user with Y/N question. If someone really likes to see manifest before installation, trigger config.

niheaven
niheaven requested changes Dec 2, 2021
View reviewed changes
lib/install.ps1 Outdated Show resolved Hide resolved
@ScoopInstaller ScoopInstaller deleted a comment from niheaven Dec 7, 2021
niheaven
niheaven requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If and only if you want to manifest-review

lib/install.ps1 Show resolved Hide resolved
@rashil2000 rashil2000 changed the base branch from master to develop December 8, 2021 09:06
@rashil2000 rashil2000 merged commit 992e993 into ScoopInstaller:develop Dec 8, 2021
@rashil2000
Copy link
Member

One side-effect of this is that it asks for manifest review even when running the scoop update * command, which becomes very annoying. @niheaven is there a way/flag to detect if the scoop update command is being used, in lib/install.ps1?

@niheaven niheaven mentioned this pull request Dec 14, 2021
Merged
@niheaven
Copy link
Member

Please test the PR.

@niheaven niheaven mentioned this pull request Dec 24, 2021
Merged
niheaven added a commit that referenced this pull request Dec 25, 2021
@niheaven @rashil2000
@Ash258 @rasa @filmor @MrNuggelz @pratikpc @nickbudi @jfastnacht @tukanos
Merge branch 'develop' into 'master' (#4594)
1dbab1f 
Related PRs:
- #4531 @filmor 
  - ac71fcc @niheaven 
- #4535 @rashil2000 
- #4522 @pratikpc 
- #4550 @niheaven 
- #4528 @niheaven 
- #4532 @MrNuggelz
- #4155 @MrNuggelz Co-authored-by: @rashil2000 
  - #4581 @niheaven 
  - fb496c4 @rashil2000 
- #4543 @rashil2000 Co-authored-by: @niheaven 
  - #4555 @rashil2000 
  - 3c90d1a @rashil2000 
  - 2ec00d5 @rashil2000 
- #4567 @rashil2000 
  - cbe29ed @rashil2000 
- #4570 @niheaven 
  - #4582 @niheaven 
- #4571 @niheaven 
- #3244 @nickbudi 
- #3821 @jfastnacht Co-authored-by: @rasa 
- #4578 @tukanos
- #4579 @rashil2000 

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
Co-authored-by: Ross Smith II <ross@smithii.com>
Co-authored-by: Benedikt Reinartz <filmor@gmail.com>
Co-authored-by: Joris <MrNuggelz@users.noreply.github.com>
Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk>
Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
Co-authored-by: nickbudi <nickbudi@users.noreply.github.com>
Co-authored-by: Julian <github@fastnacht.consulting>
Co-authored-by: tukanos <patrik.svestka@gmail.com>
@rashil2000 rashil2000 mentioned this pull request Feb 8, 2022
Merged
3 tasks
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@MrNuggelz @rashil2000 @se35710
feat(install): Show manifest on installation (ScoopInstaller#4155)
03ee6de 
* show manifest on installation

* Inline function

* Update install.ps1

Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@niheaven @rashil2000
@Ash258 @rasa @filmor @MrNuggelz @pratikpc @nickbudi @jfastnacht @tukanos @se35710
Merge branch 'develop' into 'master' (ScoopInstaller#4594)
e334b81 
Related PRs:
- ScoopInstaller#4531 @filmor
  - ac71fcc @niheaven
- ScoopInstaller#4535 @rashil2000
- ScoopInstaller#4522 @pratikpc
- ScoopInstaller#4550 @niheaven
- ScoopInstaller#4528 @niheaven
- ScoopInstaller#4532 @MrNuggelz
- ScoopInstaller#4155 @MrNuggelz Co-authored-by: @rashil2000
  - ScoopInstaller#4581 @niheaven
  - fb496c4 @rashil2000
- ScoopInstaller#4543 @rashil2000 Co-authored-by: @niheaven
  - ScoopInstaller#4555 @rashil2000
  - 3c90d1a @rashil2000
  - 2ec00d5 @rashil2000
- ScoopInstaller#4567 @rashil2000
  - cbe29ed @rashil2000
- ScoopInstaller#4570 @niheaven
  - ScoopInstaller#4582 @niheaven
- ScoopInstaller#4571 @niheaven
- ScoopInstaller#3244 @nickbudi
- ScoopInstaller#3821 @jfastnacht Co-authored-by: @rasa
- ScoopInstaller#4578 @tukanos
- ScoopInstaller#4579 @rashil2000

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
Co-authored-by: Ross Smith II <ross@smithii.com>
Co-authored-by: Benedikt Reinartz <filmor@gmail.com>
Co-authored-by: Joris <MrNuggelz@users.noreply.github.com>
Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk>
Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
Co-authored-by: nickbudi <nickbudi@users.noreply.github.com>
Co-authored-by: Julian <github@fastnacht.consulting>
Co-authored-by: tukanos <patrik.svestka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

@niheaven niheaven niheaven approved these changes

@issaclin32 issaclin32 issaclin32 approved these changes

Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask if user wants to review install script before installing packages
4 participants
@MrNuggelz @rashil2000 @issaclin32 @niheaven