-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): Fix Junction creation during installation inside containers #4837
Conversation
@rashil2000 Can you have a look at this?
All Test's passed Tests completed in 34.51s
Tests Passed: 124, Failed: 0, Skipped: 0, Pending: 0, Inconclusive: 0 |
Verified that installation succeeds in both docker & normal powershell
|
Also, please keep the |
a0793a9
to
889cba6
Compare
Done. Moved |
Hmm, looks good. One minor nit: We should keep the Also, please update the changelog |
Done! |
Removed extra line from bottom of file & trailing whitespaces .
|
dabc831
to
801e4e2
Compare
Description
Fixes installation of scoop in Dockerfile due to docker/for-win#12240
Motivation and Context
Fixes #4792
How Has This Been Tested?
Tested in windows docker & windows vm
Checklist: