Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoupdate): Copy PSCustomObject-type properties within autoupdate to prevent reference changes #5934

Merged
merged 3 commits into from
May 1, 2024

Conversation

amorphobia
Copy link
Contributor

@amorphobia amorphobia commented May 1, 2024

Description

Function Update-ManifestProperty rewrites fields in autoupdate if it is a PSCustomObject. This PR is trying to fix it.

Motivation and Context

How Has This Been Tested?

Tested with the modified manifest in #5933 and with following command:

& "$env:SCOOP_HOME/bin/checkver.ps1" -Dir <bucket_dir> -Update sudo

And only the expected value updated.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@niheaven niheaven changed the title fix(autoupdate): deep copy manifest fields fix(autoupdate): Copy PSCustomObject-type properties within autoupdate to prevent reference changes May 1, 2024
@niheaven
Copy link
Member

niheaven commented May 1, 2024

btw, please create a new branch to submit PR.

@niheaven niheaven merged commit b8580aa into ScoopInstaller:develop May 1, 2024
2 checks passed
niheaven pushed a commit that referenced this pull request May 13, 2024
niheaven pushed a commit that referenced this pull request May 13, 2024
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants