Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples on the homepage, customized page titles #31

Merged
merged 9 commits into from
Jun 30, 2022
Merged

Conversation

gpailler
Copy link
Collaborator

@gpailler gpailler changed the title Updated examples on the homepage, customized titles Updated examples on the homepage, customized page titles Jun 23, 2022
@gpailler
Copy link
Collaborator Author

@rashil2000 Feel free to approve the merge if it looks good to you https://scoop.sh/scoopinstaller-dev.github.io/

src/components/Home.tsx Outdated Show resolved Hide resolved
@rashil2000
Copy link
Member

I was planning replace to replace vscode with neovim (because it's in Main), but this idea is better!

I think we should do neovim + vscode, because 7zip is an internal dependency of Scoop and usually gets installed automatically.

@gpailler
Copy link
Collaborator Author

I was looking for a mainstream package in main but you are right, 7zip is probably not the best choice.
What about python then? I think it's one of the most popular package we can imagine

@rashil2000
Copy link
Member

rashil2000 commented Jun 24, 2022

Python is already used as example in the next paragraph 😅

@gpailler
Copy link
Collaborator Author

Yes, and it show a continuity in the examples, don't you think?
Do you have any other mainstream package in mind?

@rashil2000
Copy link
Member

The example should have both bin and shortcuts, should be a popular one and be present in the Main bucket 😅

Apart from Neovim, there's DOSBox and PostgreSQL that I can think of...

@gpailler
Copy link
Collaborator Author

What a challenge 😄 !
I think we should focus on the most popular programs for a first 'wow' effect, not sure the bin and shortcuts are that important in theses examples.

What about adding even more examples ?
K6PG2BDKuX

@sitiom
Copy link

sitiom commented Jun 28, 2022

Perhaps you can display the examples as embed asciinema recordings for some interactivity. What do you think?

Edit: Nvm, didn't see #24.

@rashil2000
Copy link
Member

What about adding even more examples ?

I like this idea. But I still think Python can be skipped (Node.js is similar to it, and also 4 examples are enough 😅)

@gpailler
Copy link
Collaborator Author

Done. Python is removed and replaced with Node.js as a first example

@rashil2000
Copy link
Member

Great!

I've pushed a commit to update search command output in accordance with ScoopInstaller/Scoop#4997

@gpailler
Copy link
Collaborator Author

Looks good! Feel free to merge then

@rashil2000 rashil2000 merged commit 0dc929a into main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front page has non working example
3 participants