Respect URL params & display correct bucket content #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two main issues in the search and bucket components. Firstly, it ensures that search parameters from the URL are respected, and secondly, it allows correct display of bucket content when clicking on non-official repositories. Changes made: 1. In Search.tsx, modified the code to read and set sortIndex, sortDirection, and searchOfficialOnly from the URL parameters using getSortIndexFromSearchParams, getSortDirectionFromSearchParams, and getSearchOfficialOnlyFromSearchParams, respectively. 2. Updated handleSortChange and handleSearchOfficialOnlyChange to set the respective state variables directly, instead of updating the URL parameters first. 3. In Buckets.tsx, changed the 'search' property of the 'Link' component to include the official flag in the query parameters, ensuring that the bucket content is displayed correctly for non-official repositories.
|
Looks good thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
This commit addresses two main issues in the search and bucket components. Firstly, it ensures that search parameters from the URL are respected, and secondly, it allows correct display of bucket content when clicking on non-official repositories.
Changes made: