Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Swap and Bribe Contract Functionality #3

Merged
merged 10 commits into from
May 4, 2021
Merged

Core Swap and Bribe Contract Functionality #3

merged 10 commits into from
May 4, 2021

Conversation

apbendi
Copy link
Member

@apbendi apbendi commented Apr 28, 2021 •
edited
Loading

Implements and tests the core swap-and-bribe functionality required.

Current limitation: does not allow ETH profits to be withdrawn from the contract. See #6.

mds1
mds1 reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the tests closely, just took a quick review with lots of small comments

contracts/contracts/SwapBriber.sol Outdated Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Outdated Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Outdated Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Outdated Show resolved Hide resolved
contracts/test/SwapBriber.ts Show resolved Hide resolved
@apbendi
Implement Swap portion of swapAndBribe
ab91812 
* Set up Uniswap router and WETH/Token pool in our
  tests
* Implement and test swapping functionality
@apbendi
Pay and test coinbase tip
2b9e3f2 
Also removes template artifacts & updates contract to use
SafeApprove
@apbendi
Deploy script + deployment to goerli
c127875
@apbendi apbendi requested review from mds1 and wildmolasses May 4, 2021 11:14
@apbendi apbendi changed the title MVP Contract Implementation Core Swap and Bribe Contract Functionality May 4, 2021
@apbendi apbendi marked this pull request as ready for review May 4, 2021 11:15
mds1
mds1 suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few more comments, nothing major though, especially since we know it all works on Goerli already 🥳

contracts/contracts/SwapBriber.sol Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Show resolved Hide resolved
contracts/contracts/SwapBriber.sol Show resolved Hide resolved
contracts/scripts/deploy.js Outdated Show resolved Hide resolved
contracts/test/SwapBriber.ts Show resolved Hide resolved
contracts/test/SwapBriber.ts Show resolved Hide resolved
@apbendi apbendi merged commit 5d344d7 into main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 requested changes

@wildmolasses wildmolasses Awaiting requested review from wildmolasses

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apbendi @mds1