-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only copy over the queue information to the worker static config #311
only copy over the queue information to the worker static config #311
Conversation
LGTM |
I am getting errors when deploying to non default namespaces. The daemonsets are only getting deployed to default namespace. |
This might not be related to this issue? I don't think worker CFG decides where workers get deployed. I think this is just how app behaved all along, and we could track this as a separate issue |
Hm, interesting app has access to deploy to other namespaces, Perhaps we can downgrade perms from cluster role, to role for this one |
It might not be related to this issue, but an interesting issue for sure. I am assuming it was never deployed in a non default namespace for lockdown because nsq would not work at all. Will decrease the perms for cluster role then. |
I think we can do following:
|
…elated-information-passed-to-workers' into 283-removal-of-sensitive-and-unrelated-information-passed-to-workers
good to go. |
No description provided.