-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v2 endpoints #339
Conversation
having issues with policy, report, and competitions v2 proto files. The go stub from buf don't seem to have the getunaryrequest for policy and report. While the competition go stubs don't have the correct version of the competition message. I fixed these things in a PR ScoreTrak/scoretrakapis#17. |
fixed the buf version conflict issue. go.buf.build/grpc/go/scoretrak/scoretrakapis was stuck at v1.4.14 and installing the latest repo was not updating the go package mentioned, https://github.com/ScoreTrak/ScoreTrak/pull/339/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L26. Removing the line linked and go mod tidy force go to find the right version. |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=========================================
- Coverage 14.06% 8.25% -5.81%
=========================================
Files 31 45 +14
Lines 2581 4397 +1816
=========================================
Hits 363 363
- Misses 2189 4005 +1816
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
merge some desired changes in client so testing v2 endpoints is possible :). I am interesting in using the connect-web library rather than the grpc-web. You can intialize interceptor in one go and don't have to create an object storing all of the clients. In addition, the object are much eaiser to handle rather than the get set methods. https://connect.build/. It supports both connect and grpc protocol. |
v2 endpoints are solid, just need to register with the auth interceptor which is a pain :(. |
not as much of a pain as I thought it would be. Adding v2 endpoints to clients :). |
v2 endpoints finished and tested on macos. I was getting seg faults errors with policyclient but am blaming that on macos. will test with docker (🔥 💻 😢 ) locally. |
Tested within a dev container and the issues mentioned above did not arise (segfault due to macos then :)). endpoints should be good to go. Need to update the buf package name inorder to implement connect server and handlers. Want to look into better migration tool. improved db models, and add support for other db, and rework the runner. |
No description provided.