Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2 endpoints #339

Merged
merged 21 commits into from
Jan 30, 2023
Merged

Implement v2 endpoints #339

merged 21 commits into from
Jan 30, 2023

Conversation

thisisibrahimd
Copy link
Member

No description provided.

@thisisibrahimd thisisibrahimd changed the title add v2 endpoint with changes to server init and telemetry Implement v2 endpoints Dec 31, 2022
@thisisibrahimd
Copy link
Member Author

having issues with policy, report, and competitions v2 proto files. The go stub from buf don't seem to have the getunaryrequest for policy and report. While the competition go stubs don't have the correct version of the competition message. I fixed these things in a PR ScoreTrak/scoretrakapis#17.

@thisisibrahimd
Copy link
Member Author

fixed the buf version conflict issue. go.buf.build/grpc/go/scoretrak/scoretrakapis was stuck at v1.4.14 and installing the latest repo was not updating the go package mentioned, https://github.com/ScoreTrak/ScoreTrak/pull/339/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L26. Removing the line linked and go mod tidy force go to find the right version.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #339 (86c0187) into master (2c47925) will decrease coverage by 5.81%.
The diff coverage is 0.24%.

@@            Coverage Diff            @@
##           master    #339      +/-   ##
=========================================
- Coverage   14.06%   8.25%   -5.81%     
=========================================
  Files          31      45      +14     
  Lines        2581    4397    +1816     
=========================================
  Hits          363     363              
- Misses       2189    4005    +1816     
  Partials       29      29              
Impacted Files Coverage Δ
pkg/handler/authv1.grpc.go 0.00% <0.00%> (ø)
pkg/handler/authv2.grpc.go 0.00% <0.00%> (ø)
pkg/handler/checkv2.grpc.go 0.00% <0.00%> (ø)
pkg/handler/competitionv1.grpc.go 0.00% <0.00%> (ø)
pkg/handler/competitionv2.grpc.go 0.00% <0.00%> (ø)
pkg/handler/configv1.grpc.go 0.00% <0.00%> (ø)
pkg/handler/configv2.grpc.go 0.00% <0.00%> (ø)
pkg/handler/healthv1.grpc.go 0.00% <0.00%> (ø)
pkg/handler/host_groupv1.grpc.go 0.00% <0.00%> (ø)
pkg/handler/host_groupv2.grpc.go 0.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thisisibrahimd
Copy link
Member Author

thisisibrahimd commented Jan 13, 2023

merge some desired changes in client so testing v2 endpoints is possible :). I am interesting in using the connect-web library rather than the grpc-web. You can intialize interceptor in one go and don't have to create an object storing all of the clients. In addition, the object are much eaiser to handle rather than the get set methods. https://connect.build/. It supports both connect and grpc protocol.

@thisisibrahimd
Copy link
Member Author

v2 endpoints are solid, just need to register with the auth interceptor which is a pain :(.

@thisisibrahimd
Copy link
Member Author

not as much of a pain as I thought it would be. Adding v2 endpoints to clients :).

@thisisibrahimd
Copy link
Member Author

v2 endpoints finished and tested on macos. I was getting seg faults errors with policyclient but am blaming that on macos. will test with docker (🔥 💻 😢 ) locally.

@thisisibrahimd
Copy link
Member Author

thisisibrahimd commented Jan 30, 2023

Tested within a dev container and the issues mentioned above did not arise (segfault due to macos then :)). endpoints should be good to go. Need to update the buf package name inorder to implement connect server and handlers. Want to look into better migration tool. improved db models, and add support for other db, and rework the runner.

@thisisibrahimd thisisibrahimd merged commit d89e817 into master Jan 30, 2023
@thisisibrahimd thisisibrahimd deleted the feat-implement-v2_endpoints branch February 5, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant