Finalize v5.0: resolve all TODO mainnet #779

aslesarenko · 2022-02-03T20:44:38Z

In this PR:

Closes Missing GroupElement.multiply costing #597 (see property("GroupElement.multiply equivalence"))
Implement validation for positive integer parsing. #762
Publish a snapshot only if env.HAS_SECRETS == 'true'
replace treeWithSegregation usages in tests with mkTestErgoTree
tests for GroupElement.exp via MethodCall node
test for Global.xor can be called via MethodCall node
test for Coll.getOrElse,append,slice,exists,forall can be called via MethodCall node
removing pattern cases for Coll.map, Coll.fold, Option.isDefined from CompiletimeCosting.scala (the logic is moved to the corresponding SMethod declaration)
v5.0-fix-test-for-headers: add new test for headers #780
v5.0-test-nested-loops: Test for map inside fold #788

…rsion Activation of v5.0

Implement validation for positive integer parsing.

…kTestErgoTree

codecov · 2022-02-03T21:33:03Z

Codecov Report

Merging #779 (9770e99) into v5.0-finalize (5cdf87a) will increase coverage by 0.02%.
The diff coverage is 95.45%.

@@                Coverage Diff                @@
##           v5.0-finalize     #779      +/-   ##
=================================================
+ Coverage          71.74%   71.77%   +0.02%     
=================================================
  Files                248      248              
  Lines              18803    18814      +11     
  Branches             644      636       -8     
=================================================
+ Hits               13491    13504      +13     
+ Misses              5312     5310       -2

Impacted Files	Coverage Δ
sigmastate/src/main/scala/sigmastate/Values.scala	`82.78% <ø> (ø)`
...ain/scala/sigmastate/eval/CompiletimeCosting.scala	`94.00% <ø> (+3.37%)`	⬆️
...gmastate/src/main/scala/sigmastate/eval/Zero.scala	`58.06% <0.00%> (ø)`
...ala/sigmastate/serialization/ValueSerializer.scala	`68.28% <ø> (ø)`
...ain/scala/special/collection/CollsOverArrays.scala	`86.74% <100.00%> (ø)`
...main/scala/org/ergoplatform/ErgoBoxCandidate.scala	`92.72% <100.00%> (ø)`
...n/scala/org/ergoplatform/ErgoLikeTransaction.scala	`85.10% <100.00%> (ø)`
...validation/SigmaValidationSettingsSerializer.scala	`100.00% <100.00%> (ø)`
...astate/src/main/scala/sigmastate/AvlTreeData.scala	`97.22% <100.00%> (ø)`
...igmastate/serialization/BlockValueSerializer.scala	`100.00% <100.00%> (ø)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1659cbd...9770e99. Read the comment docs.

# Conflicts: # sigmastate/src/main/scala/org/ergoplatform/ErgoLikeTransaction.scala # sigmastate/src/main/scala/sigmastate/serialization/FuncValueSerializer.scala # sigmastate/src/main/scala/sigmastate/serialization/transformers/SigmaTransformerSerializer.scala

…succeed for v5.x

…ilder and removed case from CompiletimeCosting)

…ll (added irBuilder and removed case from CompiletimeCosting)

…m CompiletimeCosting.scala

v5.0-fix-test-for-headers: add new test for headers

…o-mainnet

…n.get, Option.getOrElse from CompiletimeCosting.scala

…-mainnet # Conflicts: # sigmastate/src/test/scala/special/sigma/SigmaDslSpecification.scala

… in property("nested loops: map inside fold")

v5.0-test-nested-loops: Test for map inside fold

…e-interpreter into v5.0-todo-mainnet

library-impl/src/main/scala/special/collection/CollsOverArrays.scala

sigmastate/src/main/scala/sigmastate/utxo/transformers.scala

kushti · 2022-05-05T21:13:17Z

sigmastate/src/main/scala/sigmastate/types.scala

@@ -1427,8 +1436,22 @@ object SCollection extends STypeCompanion with MethodByNameUnapply {
        ArgInfo("index", "index of the element of this collection"),
        ArgInfo("default", "value to return when \\lst{index} is out of range"))

+  /** Implements evaluation of Coll.map method call ErgoTree node.


wrong scaladoc

…o-mainnet

jozanek and others added 10 commits December 22, 2021 13:03

Implement validation for positive integer parsing.

138c34c

codecov-badge: badges added to README.md

b3b9b69

Merge pull request #748 from ScorexFoundation/v5.0-increase-script-ve…

6d384ec

…rsion Activation of v5.0

Publish a snapshot only if env.HAS_SECRETS == 'true'

5024f23

Merge pull request #762 from jozanek/v5.0-validate-positive-integer

251784a

Implement validation for positive integer parsing.

v5.0-todo-mainnet: refactor ErgoTreeSerializerSpecification.scala

bc6ea0f

v5.0-todo-mainnet: replace treeWithSegregation usages in tests with m…

81300fd

…kTestErgoTree

v5.0-todo-mainnet: tests for GroupElement.exp via MethodCall node

36a7c03

v5.0-todo-mainnet: tests for GroupElement.multiply

63d4ae1

v5.0-todo-mainnet: cleanup

42c3938

aslesarenko mentioned this pull request Feb 3, 2022

Release Candidate v5.0 #758

Merged

21 tasks

aslesarenko added this to the v5.0 milestone Feb 3, 2022

aslesarenko and others added 14 commits February 5, 2022 20:48

v5.0-todo-mainnet: Global.xor can be called via MethodCall node

5c4ef17

v5.0-todo-mainnet: Coll.getOrElse can be called via MethodCall

c5e005f

v5.0-fix-test-for-headers: add new test for headers: fails for v4.x, …

4b422d9

…succeed for v5.x

v5.0-todo-mainnet: test case for Coll.append as MethodCall

5442dc2

v5.0-todo-mainnet: test case for Coll.slice as MethodCall (added irBu…

d1d8e71

…ilder and removed case from CompiletimeCosting)

v5.0-todo-mainnet: test case for Coll.exists, Coll.forall as MethodCa…

0dfd513

…ll (added irBuilder and removed case from CompiletimeCosting)

v5.0-todo-mainnet: removing pattern cases for Coll.map, Coll.fold fro…

25a4f5b

…m CompiletimeCosting.scala

Merge pull request #780 from jozanek/v5.0-fix-test-for-headers

71f3ed3

v5.0-fix-test-for-headers: add new test for headers

v5.0-todo-mainnet: updated tests for Coll.fold

e6b0148

Merge remote-tracking branch 'origin/v5.0-todo-mainnet' into v5.0-tod…

a082eb3

…o-mainnet

v5.0-todo-mainnet: fix test

27a38ef

v5.0-todo-mainnet: removing pattern cases for Option.isDefined, Optio…

5c6a053

…n.get, Option.getOrElse from CompiletimeCosting.scala

v5.0-todo-mainnet: fix tests

c2719fe

aslesarenko requested a review from kushti March 17, 2022 10:46

aslesarenko added 2 commits March 28, 2022 14:26

Merge remote-tracking branch 'origin/v5.0-fix-xorOf-2' into v5.0-todo…

b92e479

…-mainnet # Conflicts: # sigmastate/src/test/scala/special/sigma/SigmaDslSpecification.scala

v5.0-todo-mainnet: add TODO cover v5.x

a3b0645

jozanek and others added 6 commits April 1, 2022 10:55

v5.0-test-nested-loops:

08b3810

v5.0-test-nested-loops: fix property("nested loops: map inside fold")

9bae653

v5.0-test-nested-loops: check exception when !lowerMethodCallsInTests…

ee22a64

… in property("nested loops: map inside fold")

v5.0-test-nested-loops: roll back BitOp case

48aba69

v5.0-test-nested-loops: remove unnecessary code.

53ea2a4

Merge pull request #788 from ScorexFoundation/v5.0-test-nested-loops

77b96b1

v5.0-test-nested-loops: Test for map inside fold

aslesarenko changed the base branch from v5.0-fix-xorOf-2 to v5.0-finalize April 5, 2022 21:24

aslesarenko added the S-ready-for-review Status: This PR is ready for review label Apr 25, 2022

Merge branch 'v5.0-finalize' of github.com:ScorexFoundation/sigmastat…

1bc187f

…e-interpreter into v5.0-todo-mainnet

kushti requested changes May 5, 2022

View reviewed changes

aslesarenko added 3 commits May 6, 2022 10:31

v5.0-todo-mainnet: rollback Value.checkType call

83a4066

v5.0-todo-mainnet: address review comments

9e271ca

Merge remote-tracking branch 'origin/v5.0-todo-mainnet' into v5.0-tod…

9770e99

…o-mainnet

aslesarenko requested a review from kushti May 6, 2022 08:44

kushti approved these changes May 9, 2022

View reviewed changes

aslesarenko merged commit d6dc354 into v5.0-finalize May 9, 2022

aslesarenko mentioned this pull request May 9, 2022

Missing GroupElement.multiply costing #597

Closed

kushti deleted the v5.0-todo-mainnet branch November 6, 2023 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finalize v5.0: resolve all TODO mainnet #779

Finalize v5.0: resolve all TODO mainnet #779

aslesarenko commented Feb 3, 2022 •

edited

codecov bot commented Feb 3, 2022 •

edited

kushti May 5, 2022

aslesarenko May 6, 2022

Finalize v5.0: resolve all TODO mainnet #779

Finalize v5.0: resolve all TODO mainnet #779

Conversation

aslesarenko commented Feb 3, 2022 • edited

codecov bot commented Feb 3, 2022 • edited

Codecov Report

kushti May 5, 2022

Choose a reason for hiding this comment

aslesarenko May 6, 2022

Choose a reason for hiding this comment

aslesarenko commented Feb 3, 2022 •

edited

codecov bot commented Feb 3, 2022 •

edited