Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5.x] Cross-compilation to 2.11, 2.12, 2.13 #815

Merged
merged 32 commits into from Jan 26, 2023
Merged

Conversation

aslesarenko
Copy link
Collaborator

@aslesarenko aslesarenko commented Jun 28, 2022

Closes #806

This PR makes code changes necessary for cross-compilation to Scala 2.11, 2.12, 2.13

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #815 (1912384) into v5.0.4-RC (dab64a3) will decrease coverage by 0.17%.
The diff coverage is 54.89%.

@@              Coverage Diff              @@
##           v5.0.4-RC     #815      +/-   ##
=============================================
- Coverage      76.00%   75.84%   -0.17%     
=============================================
  Files            209      209              
  Lines          13926    13898      -28     
  Branches         468      453      -15     
=============================================
- Hits           10585    10541      -44     
- Misses          3341     3357      +16     
Impacted Files Coverage Δ
common/src/main/scala/scalan/package.scala 100.00% <ø> (ø)
common/src/main/scala/scalan/util/GraphUtil.scala 100.00% <ø> (ø)
...ommon/src/main/scala/scalan/util/ProcessUtil.scala 0.00% <0.00%> (ø)
common/src/main/scala/scalan/util/StringUtil.scala 47.82% <ø> (ø)
core/src/main/scala/scalan/Base.scala 64.55% <0.00%> (ø)
core/src/main/scala/scalan/MethodCalls.scala 56.45% <ø> (+1.61%) ⬆️
...main/scala/scalan/compilation/GraphVizExport.scala 57.77% <0.00%> (ø)
...e/src/main/scala/scalan/primitives/Functions.scala 66.44% <ø> (ø)
core/src/main/scala/scalan/primitives/Thunks.scala 59.82% <ø> (ø)
core/src/main/scala/scalan/staged/AstGraphs.scala 83.01% <ø> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aslesarenko aslesarenko changed the base branch from v5.x-update-deps to v5.x-remove-runtimecosting September 3, 2022 12:45
@kii-dot
Copy link
Contributor

kii-dot commented Sep 4, 2022

<3

@aslesarenko aslesarenko mentioned this pull request Oct 19, 2022
21 tasks
@aslesarenko aslesarenko linked an issue Dec 8, 2022 that may be closed by this pull request
@aslesarenko aslesarenko changed the base branch from v5.x-remove-runtimecosting to v5.0.1-RC December 20, 2022 10:11
…2.13

# Conflicts:
#	sigmastate/src/main/scala/org/ergoplatform/ErgoLikeContext.scala
@aslesarenko aslesarenko changed the base branch from v5.0.1-RC to v5.0.4-RC December 27, 2022 15:54
Copy link
Contributor

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to get debox dependency reviewed first. And to be reviewed, it should contain description (why forked and what changed).

build.sbt Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
Copy link
Contributor

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinking it is good time to add building instructions to readme as well (including how to build for all the supported Scala versions)

kushti
kushti previously approved these changes Jan 26, 2023
@aslesarenko aslesarenko changed the base branch from v5.0.4-RC to master January 26, 2023 20:03
@aslesarenko aslesarenko dismissed kushti’s stale review January 26, 2023 20:03

The base branch was changed.

@aslesarenko aslesarenko merged commit dce7705 into master Jan 26, 2023
@aslesarenko aslesarenko deleted the v5.x-migrate-to-2.13 branch May 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-compilation to Scala 2.13
3 participants