Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve all TODO v5.x #911

Merged
merged 10 commits into from Aug 31, 2023
Merged

Resolve all TODO v5.x #911

merged 10 commits into from Aug 31, 2023

Conversation

aslesarenko
Copy link
Collaborator

@aslesarenko aslesarenko commented Aug 19, 2023 •
edited

In this PR:

@aslesarenko aslesarenko added this to the v5.x milestone Aug 19, 2023
@aslesarenko aslesarenko marked this pull request as draft August 19, 2023 20:33
@aslesarenko aslesarenko marked this pull request as ready for review August 28, 2023 12:12
ccellado
ccellado approved these changes Aug 29, 2023
View reviewed changes
Copy link

@ccellado ccellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aslesarenko aslesarenko merged commit aa41958 into v5.0.11-RC Aug 31, 2023
4 checks passed
@aslesarenko aslesarenko mentioned this pull request Aug 31, 2023
Merged
@aslesarenko aslesarenko deleted the todo-v5.x branch September 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

@ccellado ccellado ccellado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aslesarenko @kushti @ccellado