Dbinteraction #228
Merged
Dbinteraction #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed some logice to remove unnecessary db call
amitrnec
reviewed
Jun 25, 2021
| try { | ||
| return queryDAO.query(qp); | ||
| } catch (Exception e) { | ||
| throw new ResponseException(ErrorType.TenantNotFound); |
There was a problem hiding this comment.
[minor]Use generic error message "e.getMessage()" instead of "ErrorType.TenantNotFound)"
| try { | ||
| String tenantId = qp.getTenant(); | ||
| template = getJDBCTemplate(tenantId); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
[minor]Handle "ResponseException" instead of "Exception".
| synchronized (readerJdbcTemplate) { | ||
| readerJdbcTemplate = new JdbcTemplate(masterDataSource); | ||
| } | ||
|
|
||
| // String databasename="ngbcsource2"; | ||
| // SELECT EXISTS(SELECT datname FROM pg_database WHERE datname = 'tenant2'); | ||
| String sql = "SELECT database_name FROM tenant WHERE tenant_id = ?"; |
There was a problem hiding this comment.
[major]only suggestion, No need to write the select query operation here so we can compare "tenantidValue"with append string with prefix database name "ngb" like as ngb+tenantidValue..
arpitNEC
approved these changes
Jul 9, 2021
pawannec
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the db handling and adresses a few bugs introduced by tenant handling