Initial fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better readme
Unsure about this change, we need to see the json responses from more cars
|
Happy to compare, I haven't seen that on mine, what vehicle do you have? |
|
Ex-demo Nissan Leaf 30kWh
…On 18 December 2016 at 21:25, Scott Helme ***@***.***> wrote:
Happy to compare, I haven't seen that on mine, what vehicle do you have?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFy_volY_lojXsSrnHW8I807J-HPNHkXks5rJaSvgaJpZM4LQGlG>
.
--
Phil
|
|
Mine is the 24kWh Gen 2, here is my JSON: |
|
This is me. The vin is identical in all places, it's not that there are two
different vins used.
So it seams that I get a VehicleInfoList and you don't!
{ "status": 200, "sessionId": "80f03db3-b573-43cf-9678-a67900cbe976",
"VehicleInfoList": { "VehicleInfo": [ { "nickname": "Leaf1filc",
"telematicsEnabled": "true", "vin": "*snip*" } ], "vehicleInfo": [ {
"nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "*snip*",
"custom_sessionid":
"8l+dYKLHBac/gZ6nqX9sLAblv3K/i4A+8RBQxCCGoQx+ws6I6dj2Aex9Uk/gC8PhbsImJLZ7nE4kwjidsZUBy2wZFKBUTPkWN0eRlUcagruQ=="
} ] }, "vehicle": { "profile": { "vin": "*snip*", "gdcUserId": "",
"gdcPassword": "", "encAuthToken":
"47D6C6131CF49BAA745DC75BEECD6E9A3675FC72382DF52A0266741F14B92C21", "dcmId":
"203560402152", "nickname": "Leaf1filc" } }, "EncAuthToken":
"47D6C6131CF49BAA745DC75BEECD6E9A9FF86884042A38C62B6880426B1D931C",
"CustomerInfo": { "UserId": "G4W75M64ZYIAWTF1", "Language": "en-GB",
"Timezone": "Europe/London", "RegionCode": "NE", "OwnerId": "4063912000",
"EMailAddress": "filcole@gmail.com", "Nickname": "Leaf1filc", "Country":
"GB", "VehicleImage": "/content/language/default/images/img/ph_car.jpg",
"UserVehicleBoundDurationSec": "946771200", "VehicleInfo": { "VIN": "*snip*",
"DCMID": "*snip*", "SIMID": "*snip*", "NAVIID": "*snip*", "EncryptedNAVIID":
"*snip*", "MSN": "*snip*", "LastVehicleLoginTime": "",
"UserVehicleBoundTime": "2016-09-06T12:20:25Z", "LastDCMUseTime": "" } },
"UserInfoRevisionNo": "1" }
…On 18 December 2016 at 21:30, Scott Helme ***@***.***> wrote:
Mine is the 24kWh Gen 2, here is my JSON:
array(6) {
["status"]=>
int(200)
["vehicleInfo"]=>
array(1) {
[0]=>
array(5) {
["vin"]=>
string(17) "*snip*"
["nickname"]=>
string(4) "Leaf"
["charger20066"]=>
string(5) "false"
["telematicsEnabled"]=>
string(4) "true"
["custom_sessionid"]=>
string(110) "*snip*"
}
}
["vehicle"]=>
array(1) {
["profile"]=>
array(8) {
["vin"]=>
string(17) "*snip*"
["gdcUserId"]=>
string(0) ""
["gdcPassword"]=>
string(0) ""
["encAuthToken"]=>
string(64) "*snip*"
["dcmId"]=>
string(12) "*snip*"
["status"]=>
string(4) "true"
["statusDate"]=>
string(17) "*snip*"
["nickname"]=>
string(4) "Leaf"
}
}
["EncAuthToken"]=>
string(80) "*snip*"
["CustomerInfo"]=>
array(11) {
["UserId"]=>
string(10) "*snip*"
["Language"]=>
string(5) "en_GB"
["Timezone"]=>
string(12) "Europe/Paris"
["RegionCode"]=>
string(2) "NE"
["OwnerId"]=>
string(10) "*snip*"
["EMailAddress"]=>
string(21) "*snip*"
["Nickname"]=>
string(4) "Leaf"
["Country"]=>
string(2) "GB"
["VehicleImage"]=>
string(47) "/content/language/default/images/img/ph_car.jpg"
["UserVehicleBoundDurationSec"]=>
string(9) "*snip*"
["VehicleInfo"]=>
array(9) {
["VIN"]=>
string(17) "*snip*"
["DCMID"]=>
string(12) "*snip*"
["SIMID"]=>
string(20) "*snip*"
["NAVIID"]=>
string(12) "*snip*"
["EncryptedNAVIID"]=>
string(32) "*snip*"
["MSN"]=>
string(15) "*snip*"
["LastVehicleLoginTime"]=>
string(0) ""
["UserVehicleBoundTime"]=>
string(20) "*snip*"
["LastDCMUseTime"]=>
string(17) "*snip*"
}
}
["UserInfoRevisionNo"]=>
string(1) "1"
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFy_vgJZVku_GO7_FZCIt-vZ78j7CO16ks5rJaYQgaJpZM4LQGlG>
.
--
Phil
|
Some cars seem to return a VehicleInfoList, some don't.
|
I've updated the pull request to cater for the differences in the
responses. Let me know what you think.
…On 18 December 2016 at 21:44, Phil Cole ***@***.***> wrote:
This is me. The vin is identical in all places, it's not that there are
two different vins used.
So it seams that I get a VehicleInfoList and you don't!
{ "status": 200, "sessionId": "80f03db3-b573-43cf-9678-a67900cbe976",
"VehicleInfoList": { "VehicleInfo": [ { "nickname": "Leaf1filc",
"telematicsEnabled": "true", "vin": "*snip*" } ], "vehicleInfo": [ {
"nickname": "Leaf1filc", "telematicsEnabled": "true", "vin": "*snip*",
"custom_sessionid": "8l+dYKLHBac/gZ6nqX9sLAblv3K/i4A+8RBQxCCGoQx+
ws6I6dj2Aex9Uk/gC8PhbsImJLZ7nE4kwjidsZUBy2wZFKBUTPkWN0eRlUcagruQ==" } ]
}, "vehicle": { "profile": { "vin": "*snip*", "gdcUserId": "",
"gdcPassword": "", "encAuthToken": "47D6C6131CF49BAA745DC75BEECD6E
9A3675FC72382DF52A0266741F14B92C21", "dcmId": "203560402152", "nickname":
"Leaf1filc" } }, "EncAuthToken": "47D6C6131CF49BAA745DC75BEECD6E
9A9FF86884042A38C62B6880426B1D931C", "CustomerInfo": { "UserId":
"G4W75M64ZYIAWTF1", "Language": "en-GB", "Timezone": "Europe/London",
"RegionCode": "NE", "OwnerId": "4063912000", "EMailAddress": "
***@***.***", "Nickname": "Leaf1filc", "Country": "GB",
"VehicleImage": "/content/language/default/images/img/ph_car.jpg",
"UserVehicleBoundDurationSec": "946771200", "VehicleInfo": { "VIN":
"*snip*", "DCMID": "*snip*", "SIMID": "*snip*", "NAVIID": "*snip*",
"EncryptedNAVIID": "*snip*", "MSN": "*snip*", "LastVehicleLoginTime": "",
"UserVehicleBoundTime": "2016-09-06T12:20:25Z", "LastDCMUseTime": "" } },
"UserInfoRevisionNo": "1" }
On 18 December 2016 at 21:30, Scott Helme ***@***.***>
wrote:
> Mine is the 24kWh Gen 2, here is my JSON:
>
> array(6) {
> ["status"]=>
> int(200)
> ["vehicleInfo"]=>
> array(1) {
> [0]=>
> array(5) {
> ["vin"]=>
> string(17) "*snip*"
> ["nickname"]=>
> string(4) "Leaf"
> ["charger20066"]=>
> string(5) "false"
> ["telematicsEnabled"]=>
> string(4) "true"
> ["custom_sessionid"]=>
> string(110) "*snip*"
> }
> }
> ["vehicle"]=>
> array(1) {
> ["profile"]=>
> array(8) {
> ["vin"]=>
> string(17) "*snip*"
> ["gdcUserId"]=>
> string(0) ""
> ["gdcPassword"]=>
> string(0) ""
> ["encAuthToken"]=>
> string(64) "*snip*"
> ["dcmId"]=>
> string(12) "*snip*"
> ["status"]=>
> string(4) "true"
> ["statusDate"]=>
> string(17) "*snip*"
> ["nickname"]=>
> string(4) "Leaf"
> }
> }
> ["EncAuthToken"]=>
> string(80) "*snip*"
> ["CustomerInfo"]=>
> array(11) {
> ["UserId"]=>
> string(10) "*snip*"
> ["Language"]=>
> string(5) "en_GB"
> ["Timezone"]=>
> string(12) "Europe/Paris"
> ["RegionCode"]=>
> string(2) "NE"
> ["OwnerId"]=>
> string(10) "*snip*"
> ["EMailAddress"]=>
> string(21) "*snip*"
> ["Nickname"]=>
> string(4) "Leaf"
> ["Country"]=>
> string(2) "GB"
> ["VehicleImage"]=>
> string(47) "/content/language/default/images/img/ph_car.jpg"
> ["UserVehicleBoundDurationSec"]=>
> string(9) "*snip*"
> ["VehicleInfo"]=>
> array(9) {
> ["VIN"]=>
> string(17) "*snip*"
> ["DCMID"]=>
> string(12) "*snip*"
> ["SIMID"]=>
> string(20) "*snip*"
> ["NAVIID"]=>
> string(12) "*snip*"
> ["EncryptedNAVIID"]=>
> string(32) "*snip*"
> ["MSN"]=>
> string(15) "*snip*"
> ["LastVehicleLoginTime"]=>
> string(0) ""
> ["UserVehicleBoundTime"]=>
> string(20) "*snip*"
> ["LastDCMUseTime"]=>
> string(17) "*snip*"
> }
> }
> ["UserInfoRevisionNo"]=>
> string(1) "1"
> }
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#6 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFy_vgJZVku_GO7_FZCIt-vZ78j7CO16ks5rJaYQgaJpZM4LQGlG>
> .
>
--
Phil
--
Phil
|
|
This change would not be compatible with both vehicles though would it? |
|
Oh wait, yes it would, ignore me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onlye one I'm not sure about is the additional VehicleInfoList in leaf.js. Need to compare the json returned for a few Nissan leafs to fully understand... Can we compare?