Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbar: Support customize tick label style #1360

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

Maoyao233
Copy link
Contributor

New Contributors:
Please review CONTRIBUTING.md

Hacktoberfest Participants:
Check-out the Hacktoberfest 2021 page

Purpose:
In Colorbar, the color of the tick labels is always black, which makes it hard to be seen in dark themes. This PR adds a new TickLabelStyle function to ColorBar, so that the style can be customized.

Copy link
Member

@bclehmann bclehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably improve this by having this be automatically updated when the style changes. So that the colour of the Colorbar ticks is the same as the axis ticks.

src/ScottPlot/Plottable/Colorbar.cs Outdated Show resolved Hide resolved
@swharden
Copy link
Member

I think we could probably improve this by having this be automatically updated when the style changes. So that the colour of the Colorbar ticks is the same as the axis ticks.

For now it seems okay to leave it exposed to let the user have full control over it. I also exposed fields for customizing the tick mark length, width, and color (independent of the label color). Thanks for this PR @Maoyao233, and @bclehmann for your review!

src/ScottPlot/Plottable/Colorbar.cs Outdated Show resolved Hide resolved
@swharden swharden merged commit d725134 into ScottPlot:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants