-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finite axis lines #1399
Finite axis lines #1399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR started @bclehmann!
What would you think if I replaced double?
with double
and defaulted it to NegativeInfinity
, then used Math.Max()
in Render()
to compare it to the dims
value?
My thinking is that MaximumInfinity
describes the behavior a little more explicitly than null
If this sounds good to you I can make the change and merge it in before the next release today
PS: I posted this as a code line comment ~2 days ago but I think it got stuck in GitHub's API and was labeled "pending" that whole time so I deleted it and am re-posing as a general review comment
Sure, I used null because I find
Huh, weird, I've never gotten that before. I have seen "pending" it it's a comment as part of a review, but that goes away as soon as I complete the review (approve, suggest changes, etc) |
New Contributors:
Please review CONTRIBUTING.md
Hacktoberfest Participants:
Check-out the Hacktoberfest 2021 page
Purpose:
#1390