Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RandomNormalValue uses u1, u2 from (0,1), not [0,1) #2206

Merged

Conversation

bclehmann
Copy link
Member

Purpose:
#2189

@bclehmann
Copy link
Member Author

bclehmann commented Oct 30, 2022

I'm noticing that this test is quite fragile, it creates noisy linear data where the standard deviation of the residual is 50, but it expects a fairly tight match.

It's seeded, so it'll continue to pass provided that .NET doesn't change the behaviour of System.Random, which they do fairly often, and provided that we don't change our implementation. But I think it's probably a bad test. I noticed this when I changed the implementation to one which (accidentally) mimicked the old behaviour, but with extra calls to rand.NextDouble.

@swharden swharden linked an issue Oct 31, 2022 that may be closed by this pull request
@swharden swharden merged commit 9ef9825 into ScottPlot:main Oct 31, 2022
@swharden swharden mentioned this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normal distribution: generation algorithm
2 participants