Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rwj11/703 fix compiler warnings #19

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Conversation

rwj11
Copy link
Contributor

@rwj11 rwj11 commented Jul 27, 2020

Fix warnings presented by clang-analyzer

@rwj11
Copy link
Contributor Author

rwj11 commented Jul 27, 2020

The asserts suppress warnings with the use of VLAs, which are not in the C++ standard. A previous attempt to address the same set of warnings was rewound, so we'll see if a less invasive fix might stick.
One clang-analyzer bug does remain according to the CI system, but this is not reproduced under clang++ v10.0.

@ianhinder ianhinder merged commit 07de38b into dev Jul 27, 2020
@rwj11 rwj11 deleted the rwj11/703-fix_compiler_warnings branch August 3, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants