#13 footer component #46
Conversation
| export const FooterSection = styled.div` | ||
| position: relative; | ||
| // height: 725px; |
There was a problem hiding this comment.
Can you remove this please
| export const ConnectTitle = styled.div` | ||
| color: ${colors.blue900}; | ||
|
|
There was a problem hiding this comment.
Can you get rid of this whitespace plaese
src/components/footer/footer.js
Outdated
| </SocialSection> | ||
| <FooterSection> | ||
| <FooterImage> | ||
| <img alt="footer background image" src={data.prismicFooter.data.footer_image.url} /> |
There was a problem hiding this comment.
Can you be a little more descriptive in the alt text please?
https://moz.com/learn/seo/alt-text
| <ConnectTitle> | ||
| <Sub1>{data.prismicFooter.data.sock_title}</Sub1> | ||
| <SockEmailForm> | ||
| <input type="text" placeholder="Enter your email" /> |
There was a problem hiding this comment.
Can you add labels and such please?
https://www.w3.org/WAI/tutorials/forms/
src/components/footer/footer.js
Outdated
| <Body>{data.prismicFooter.data.sock_description}</Body> | ||
| </SockDescription> | ||
|
|
||
| <SockCTA>Sign Up</SockCTA> |
There was a problem hiding this comment.
Make sure to add roles here for submit and such
src/components/footer/footer.js
Outdated
| <FooterContainer> | ||
| <FooterMainContent> | ||
| <SocialSection> | ||
| <FooterHeader>Powerhouse</FooterHeader> |
There was a problem hiding this comment.
Does this come from the CMS? Can you update it to do so if not please?
src/components/footer/footer.js
Outdated
| <SocialIcons> | ||
| {data.prismicFooter.data.social_media.map(social => { | ||
| return ( | ||
| <a href={social.social_link}> |
src/components/footer/footer.js
Outdated
| {data.prismicFooter.data.social_media.map(social => { | ||
| return ( | ||
| <a href={social.social_link}> | ||
| <img alt="social icon" src={social.social_icon.url} /> |
There was a problem hiding this comment.
Can you specify which social media this icon is for in the alt?
| export const FooterContainer = styled.div` | ||
| background-color: #848484; | ||
| background-color: rgb(0, 0, 0, 0.55); |
There was a problem hiding this comment.
Can you pull these into variables please
src/components/footer/footer.js
Outdated
| <FooterSection> | ||
| <FooterImage> | ||
| <img | ||
| alt="PowerHouse house footer background image" |
There was a problem hiding this comment.
Can the alt come from the CMS please?
No description provided.