Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove await in front of self.async_write_ha_state() calls #156

Merged

Conversation

Chupaka
Copy link
Contributor

@Chupaka Chupaka commented Jun 5, 2023

Adjustment as discussed in #152

@ScratMan ScratMan merged commit 9376d1c into ScratMan:master Jun 5, 2023
2 checks passed
@Chupaka Chupaka deleted the fix_await_self.async_write_ha_state branch June 6, 2023 10:04
@ScratMan
Copy link
Owner

ScratMan commented Jun 6, 2023

Unfortunately, I can't test by myself, temperature is already high. Could someone validate the behaviour?
It looks a bit strange the name of the function starts with async_ while it's not defined as an asynchronous function.

If it's working correctly I will make a new release.

@ScratMan
Copy link
Owner

ScratMan commented Jun 7, 2023

My test environment crashed, I lost its config and need to rebuild it from scratch.
I reviewed the code, and it uses the same method usage as other methods that were already working fine, so I'm going to release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants